Created a separate SQL file to create tables for the unmigrated entities #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainwane
changed the title
brainwane
requested changes
Jun 20, 2017
BenGalewsky
force-pushed
the
140_make_master_deployable
branch
from
188d14d to
5f5023f
Compare
brainwane
reviewed
Jun 21, 2017
INSTALL.md
Outdated
| 1. Create database schema and initial data. Use the seed data to create tables: | ||
| 1. Create database schema and initial data. Use the seed data to create tables | ||
| and legacy_seed to create tables for entities that have not yet | ||
| been migrated to Hibernate5: |
There was a problem hiding this comment.
Could you use this syntax to refer to seed and legacy_seed to make it clearer that these are files?
BenGalewsky
force-pushed
the
140_make_master_deployable
branch
from
5f5023f to
8c01c96
Compare
BenGalewsky
force-pushed
the
140_make_master_deployable
branch
from
8c01c96 to
65ba4b9
Compare
brainwane
approved these changes
Jun 21, 2017
|
(There are a couple wording things I can fix myself in a separate commit.) |
brainwane
added a commit
to brainwane/psm
that referenced
this pull request
Jun 21, 2017
Since the merge of pull request SolutionGuidance#182 in 83bb925 , it is now possible to run a somewhat functional installation of the PSM for development purposes.
This was referenced Jun 21, 2017
Closed
jasonaowen
added a commit
that referenced
this pull request
Jul 3, 2017
The entity backing this table, RequiredField, was deleted in bb02671. The legacy seed SQL script was developed in parallel before the deletion was merged. Delete the unused table. Issue #36 Use Hibernate 5, instead of 4 Pull request #180 Delete unused entity RequiredField Pull request #182 Created a separate SQL file to create tables for the unmigrated entities
jasonaowen
added a commit
that referenced
this pull request
Jul 6, 2017
The entity backing this table, RequiredField, was deleted in bb02671. The legacy seed SQL script was developed in parallel before the deletion was merged. Delete the unused table. Issue #36 Use Hibernate 5, instead of 4 Pull request #180 Delete unused entity RequiredField Pull request #182 Created a separate SQL file to create tables for the unmigrated entities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a DDL file
legacy_seed.sqlthat creates tables for the entities that have not yetbeen migrated to H5. This script can be run when a fresh db is set up to create the tables and get the
master branch to work. The DROP TABLE statement at the top is handy for removing all of the legacy
tables from the DB for easy testing of what needs to be converted to get workflows working.
Going forward, as we migrate entities and add them to seed.sql we should delete the DDL from legacy.sql
Progress on #148