SCAN4NET-234 Use SONAR_SCANNER_OPTS to map the new properties #2314
Conversation
hashicorp-vault-sonar-prod
bot
changed the title
sebastien-marichal
force-pushed
the
sma/props-map-2
branch
from
28b73f3 to
36383e8
Compare
sebastien-marichal
force-pushed
the
sma/props-map-2
branch
from
b9c955e to
70b2424
Compare
Tests/SonarScanner.MSBuild.Shim.Test/SonarScannerWrapperTests.cs
Outdated
Show resolved
Hide resolved
Tests/SonarScanner.MSBuild.Shim.Test/SonarScannerWrapperTests.cs
Outdated
Show resolved
Hide resolved
| /// List of analysis settings supplied locally (on the | ||
| /// command line) that has to be passed to the scanner through | ||
| /// the SONAR_SCANNER_OPTS environment variable | ||
| /// </summary> |
There was a problem hiding this comment.
| /// </summary> | |
| /// <see href="https://github.com/SonarSource/sonar-scanner-cli/blob/7d791c2465384b71465a6c05d23174fefdbfa213/src/main/assembly/bin/sonar-scanner.bat#L72C66-L72C84">sonar-scanner.bat</see> | |
| /// </summary> |
| result.Should().BeTrue(); | ||
| } | ||
|
|
||
| CheckEnvVarExists("SONAR_SCANNER_OPTS", "-Dsome.property=value -Dsome.other.property=\"another value with #%\\/?*\"", mockRunner); |
There was a problem hiding this comment.
For file names, we can expect spaces in the path. Does AsSonarScannerArg escape these? Background: Any double quotes coming via command line to the dotnet scanner are stripped off (as far as I can tell), so we would pass the file path without quotes.
There was a problem hiding this comment.
AsSonarScannerArg does not escape the spaces :(
Can we safely force the double quote?
I remember we had trouble with quote escaping in the past when invoking the bat file.
|
| @@ -43,13 +43,15 @@ public static AnalysisConfig GenerateFile(ProcessedArgs localSettings, | |||
| IDictionary<string, string> serverProperties, | |||
| List<AnalyzerSettings> analyzersSettings, | |||
| string sonarQubeVersion, | |||
| string resolvedJavaExePath) | |||
| string resolvedJavaExePath, | |||
| ILogger logger) | |||
There was a problem hiding this comment.
Adding the ILogger raised S107, I accepted the issue.
I am open to suggestion to fix it.
I need the logger to create the OperatingSystemProvider for the mapping provider.
I am open to suggestions to fix it, I would like to avoid a full rework.
I could not use OperatingSystemProvider to detect the current OS however I would probably lose testability and would create some kind of duplications.
SCAN4NET-234
Part of SCAN4NET-207