Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/cleanup #330

Merged
merged 6 commits into from
Jan 24, 2025
Merged

Feat/cleanup #330

merged 6 commits into from
Jan 24, 2025

Conversation

fkr
Copy link
Member

@fkr fkr commented Jan 24, 2025

No description provided.

fkr added 4 commits January 24, 2025 13:19
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Signed-off-by: Felix Kronlage-Dammers <[email protected]>
Copy link
Member

@matofeder matofeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berendt
Copy link

berendt commented Jan 24, 2025

Does it makes sense to also remove all of the old VP groups?

Copy link
Member

@garloff garloff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
The question is whether we want to keep historic data, so we could have "Historic SCS project team @ OSBA" (which would also include Eduard then) or the work packages (VPs).
I see no really good reason for it, so I would support @berendt 's proposal to remove the VP groups next.

@garloff garloff merged commit 178b065 into main Jan 24, 2025
5 checks passed
@garloff garloff deleted the feat/cleanup branch January 24, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants