Make healing salves consistently give the bowl back #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix any HealItem with a RETURN_STACK, but only healing salves have a return stack. |
|
after a bit more testing, this still seems to stop working after a bit, I think related to having a full inventory, but I'm not sure |
|
okay, this should be working 100% of the time now. We're now creating a new ItemStack each time, instead of giving the same ItemStack, and that seems to have fixed the problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was really frustrating that I had to keep making more bowls because it wouldn't give them back to me when the healing salve broke. I thought this was a feature, but looking at the code it seems to be a bug. This PR fixes that.