Remove discounted fee calculation logic from Deployers and Farm factory updates #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcantheon
changed the title
TechnoGeek01
approved these changes
Nov 14, 2023
arcantheon
changed the title
TechnoGeek01
approved these changes
Nov 14, 2023
YashP16
requested changes
Nov 16, 2023
| return _calculateFees(_tokenA, _tokenB); | ||
| /// @notice A public view function to get fees from Farm Factory | ||
| /// @return feeReceiver of feeToken in feeAmount | ||
| function getFees(address _deployerAccount) |
There was a problem hiding this comment.
Mark this function as external
There was a problem hiding this comment.
Resolved 06b706b
contracts/BaseFarmDeployer.sol
Outdated
| /// @dev Function fetches all the fee params from farmFactory. | ||
| function _collectFee() internal virtual { | ||
| // Here msg.sender would be the deployer/creator of the farm which will be checked in privileged deployer list | ||
| (address feeReceiver, address feeToken, uint256 feeAmount) = getFees(msg.sender); |
There was a problem hiding this comment.
Directly call the IFarmFactory() contract.
There was a problem hiding this comment.
Resolved 06b706b
YashP16
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.