CSFile Windows creation file mode fix #1205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct mode to create a file, if not exists, and open it, if exists, is CREATE_ALWAYS. With (OPEN_ALWAYS | CREATE_NEW) the mode is set to 5 (TRUNCATE_EXISTING) and if the file doesn't exists the CreateFile function return an error. https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilea
Added new file permissions
|
added creation file fix for Linux. |
|
added fix for #1206 |
|
Tested the dispid Part and now it work fine! Thx. ABout the CSfile, I don't know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct mode to create a file in Windows, if not exists, and open it, if exists, is CREATE_ALWAYS. With (OPEN_ALWAYS | CREATE_NEW) the mode is set to 5 (TRUNCATE_EXISTING) and if the file doesn't exists the CreateFile function return an error. https://learn.microsoft.com/en-us/windows/win32/api/fileapi/nf-fileapi-createfilea