Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert generated unit_ids in docs to strings #3600

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Convert generated unit_ids in docs to strings #3600

merged 1 commit into from
Jan 8, 2025

Conversation

chrishalcrow
Copy link
Collaborator

#3588 broke one of the tutorials in the docs, since the selected unit_ids were integers, but should now by string.

This PR string-ifies the unit_ids to fix the docs.

@chrishalcrow chrishalcrow added bug Something isn't working documentation Improvements or additions to documentation labels Jan 8, 2025
@chrishalcrow chrishalcrow changed the title Conver generated unit_ids in docs to strings Convert generated unit_ids in docs to strings Jan 8, 2025
@alejoe91 alejoe91 merged commit 0b1bf67 into SpikeInterface:main Jan 8, 2025
14 of 15 checks passed
@chrishalcrow chrishalcrow deleted the fix-docs-string-ids branch January 8, 2025 15:43
@h-mayorquin
Copy link
Collaborator

Thanks. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejoe91 alejoe91 alejoe91 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chrishalcrow @h-mayorquin @alejoe91