#109, Move triggering control strategies in threat explorer, #110 explain untriggered threats

[kenmeacham]

Closes #109, Closes #110, Closes #172

[kenmeacham]

After disussion, @scp93ch preferred that the "Triggering Control Strategies" panel title should be coloured red when activated, and green otherwise. This now looks as follows:

We may need to revise the colour scheme further, as the light green colouring of the CSG panel may not now make sense?

[scp93ch]

We may need to revise the colour scheme further, as the light green colouring of the CSG panel may not now make sense?

Yeah, that looks pretty weird. I suggest just removing the light green when a CSG is active in the triggering control strategies panel. In the context of the threat that is triggered, the triggering CSG is kind of a bad thing so the red accordion title is okay. I think that colouring the background pink or something might be going too far, because the CSG isn't all bad - it does do something useful.

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[kenmeacham]

We may need to revise the colour scheme further, as the light green colouring of the CSG panel may not now make sense?

Yeah, that looks pretty weird. I suggest just removing the light green when a CSG is active in the triggering control strategies panel. In the context of the threat that is triggered, the triggering CSG is kind of a bad thing so the red accordion title is okay. I think that colouring the background pink or something might be going too far, because the CSG isn't all bad - it does do something useful.

The color scheme has now been revamped, via pull request #174

I think this branch should now be ready to merge in, if you approve @scp93ch