Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish chapter "Lists, tables and trees" #98

Merged
merged 6 commits into from
May 20, 2024
Merged

Conversation

koendehondt
Copy link
Collaborator

  • Replaced all images except Moose image
  • Tried all examples
  • Improved text

@koendehondt koendehondt requested a review from Ducasse May 17, 2024 21:52
@Ducasse
Copy link
Member

Ducasse commented May 17, 2024

I will have a look.

@Ducasse
Copy link
Member

Ducasse commented May 17, 2024

Are you sure about this asStringOrText (it looks not really nice to my eyes)?

@koendehondt
Copy link
Collaborator Author

Are you sure about this asStringOrText (it looks not really nice to my eyes)?

Yes, I am sure. I checked all the code, so also this part. I was surprised too 😄.

See SpListPresenter>>#initialize:

initialize

	super initialize.
	self initializeTSearchable.
	autoDeselect := true.
	allowToSelect := true.
	display := [ :object | object asStringOrText ]

@koendehondt koendehondt linked an issue May 18, 2024 that may be closed by this pull request
1 task
@koendehondt
Copy link
Collaborator Author

@Ducasse I added all examples of this chapter to the code repo. See ListTableAndTreeExamples.
Doing so, I found a few issues in the text. I fixed them. See the latest commits.

@Ducasse
Copy link
Member

Ducasse commented May 18, 2024

In fact I would introduce a method that call Smalltalk globals allClasses because we should remove this Smalltalk variable in the future.

@Ducasse Ducasse merged commit 05a183e into master May 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish chapter "Lists, tables and trees"
2 participants