Skip to content

Commit

Permalink
docs(fundamentals): fix example-row-detail positioning (#1859)
Browse files Browse the repository at this point in the history
* docs(fundamentals): fix example-row-detail positioning

[STACKS-657](https://stackoverflow.atlassian.net/browse/STACKS-657)

* change all instances of customHeight to connectorHeight

Addresses #1859 (comment)
  • Loading branch information
dancormier authored Nov 27, 2024
1 parent df6e47b commit 707796c
Show file tree
Hide file tree
Showing 3 changed files with 22 additions and 23 deletions.
3 changes: 0 additions & 3 deletions docs/_includes/annotation.html
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
{% assign positionClasses = "mt8 fd-column" %}
{% assign height = 12 %}

{% if range != true %}
{% assign computedClasses = "mx-auto" %}
{% endif %}
{% if position == "top" %}
{% assign positionClasses = "mb8 fd-column-reverse" %}
{% endif %}
Expand Down
28 changes: 14 additions & 14 deletions docs/product/foundation/accessibility.html
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@
</button>
{% render 'annotation.html',
text: group.description,
style: "margin-left: 50%;",
customHeight: 16
classes: "mx-auto",
connectorHeight: 16
%}
</div>
{% endfor %}
Expand All @@ -135,8 +135,8 @@
</button>
{% render 'annotation.html',
text: group.description,
style: "margin-left: 50%;",
customHeight: 16
classes: "mx-auto",
connectorHeight: 16
%}
</div>
{% endfor %}
Expand All @@ -160,8 +160,8 @@

{% render 'annotation.html',
text: group.description,
style: "margin-left: 50%;",
customHeight: 16
classes: "mx-auto",
connectorHeight: 16
%}
</div>
{% endfor %}
Expand Down Expand Up @@ -199,8 +199,8 @@

{% render 'annotation.html',
text: group.description,
style: "margin-left: 50%;",
customHeight: 16
classes: "mx-auto",
connectorHeight: 16
%}
</div>
{% endfor %}
Expand Down Expand Up @@ -234,8 +234,8 @@

{% render 'annotation.html',
text: group.description,
style: "margin-left: 50%;",
customHeight: 16
classes: "mx-auto",
connectorHeight: 16
%}
</div>
{% endfor %}
Expand Down Expand Up @@ -286,8 +286,8 @@

{% render 'annotation.html',
text: group.description,
style: "margin-left: 50%;",
customHeight: 16
classes: "mx-auto",
connectorHeight: 16
%}
</div>
{% endfor %}
Expand All @@ -308,8 +308,8 @@

{% render 'annotation.html',
text: group.description,
style: "margin-left: 50%;",
customHeight: 16
classes: "mx-auto",
connectorHeight: 16
%}
</div>
{% endfor %}
Expand Down
14 changes: 8 additions & 6 deletions docs/product/foundation/color-fundamentals.html
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@
{% render 'annotation.html',
text: "Input borders",
classes: "sm:d-none",
style: "margin-left: calc((1.5/11) * 100%);"
style: "margin-left: calc((1/11) * 100%); min-width: calc((1/11) * 100%)"
%}
</div>
</div>
Expand All @@ -195,8 +195,8 @@
%}
{% render 'annotation.html',
text: "Heading",
style: "margin-left: calc((.5/11) * 100%);",
classes: "sm:d-none"
style: "min-width: calc((1/11) * 100%)",
classes: "sm:d-none fl-shrink1"
%}
</div>
</div>
Expand All @@ -212,12 +212,12 @@
<div class="d-flex w100">
{% render 'annotation.html',
text: "Illustrations",
style: "margin-left: calc((7.5/11) * 100%)",
classes: "sm:d-none"
style: "margin-left: calc((7/11) * 100%); min-width: calc((1/11) * 100%)",
classes: "sm:d-none",
%}
{% render 'annotation.html',
text: "Icons",
style: "margin-left: calc((.5/11) * 100%); width: calc((2/11) * 100%)",
style: "width: calc((2/11) * 100%)",
classes: "sm:d-none",
range: true
%}
Expand Down Expand Up @@ -344,6 +344,7 @@
<div class="fs-title {{group.textClasses}}">Text</div>
{% render 'annotation.html',
text: group.name,
classes: "mx-auto",
style: "margin-left: 50%;"
%}
</div>
Expand All @@ -363,6 +364,7 @@
<button class="s-btn s-btn__filled {{group.classes}}" {{group.attr}} role="presentation">Button</button>
{% render 'annotation.html',
text: group.name,
classes: "mx-auto",
style: "margin-left: 50%;"
%}
</div>
Expand Down

0 comments on commit 707796c

Please sign in to comment.