Skip to content

Commit

Permalink
fix(label): restore standalone styling for .s-label--status
Browse files Browse the repository at this point in the history
  • Loading branch information
dancormier committed Dec 7, 2022
1 parent a73ba0f commit f729f83
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion lib/css/components/labels.less
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
// Label status flag
// Is this form item required or optional? Flag the status for users.
// Default styling is optional.
& &--status {
&--status { // TODO convert to require parent class for styling [1]
--_la-status-b: none;
--_la-status-bg: var(--black-050);
--_la-status-fc: var(--fc-medium);
Expand Down Expand Up @@ -96,3 +96,8 @@
font-weight: 600;
padding: 0 var(--su2); // Helps the label visually line up with inputs
}

// [1] In Core, we have *many* instances of `.s-label--status` used without the `.s-label` parent.
// While I'd prefer to enforce the requirement of the parent class, it's too much of a lift at this moment.
// We'll come back to it, hopefully when we have a pill component to replace the current usage of `.s-label--status`
// without the base label class.

0 comments on commit f729f83

Please sign in to comment.