Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): upgrade eslint to v9 #1856

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

giamir
Copy link
Contributor

@giamir giamir commented Nov 14, 2024

This PR upgrades this repo to the latest version of eslint.
https://eslint.org/docs/latest/use/migrate-to-9.0.0

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for stacks failed. Why did it fail? →

Name Link
🔨 Latest commit 77d2b37
🔍 Latest deploy log https://app.netlify.com/sites/stacks/deploys/6735fdf44fe2990008b8b350

@@ -1,7 +1,5 @@
{
"recommendations": [
"dbaeumer.vscode-eslint",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing those old plugin recommendations so that the official msft vscode eslint plugin get picked up.

@giamir giamir requested a review from dancormier November 14, 2024 13:43
Copy link
Contributor

@dancormier dancormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a pretty clean migration. No notes! Thanks and sorry for the delayed review ❤️

@giamir giamir merged commit 63f7062 into develop Nov 26, 2024
7 of 11 checks passed
@giamir giamir deleted the gbuoncristiani/upgrade-eslint branch November 26, 2024 08:25
giamir added a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants