Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(fundamentals): fix example-row-detail positioning #1859

Merged
merged 3 commits into from
Nov 27, 2024
Merged

docs(fundamentals): fix example-row-detail positioning #1859

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdc4024
docs(fundamentals): fix example-row-detail positioning
dancormier Nov 22, 2024
ba66ab7
change all instances of customHeight to connectorHeight
dancormier Nov 26, 2024
57789bc
Merge branch 'develop' into STACKS-657/example-row-detail-positioning
dancormier Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions docs/_includes/example-row-detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,6 @@
{% assign positionClasses = "mt8 fd-column" %}
{% assign height = 12 %}

{% if range != true %}
{% assign computedClasses = "mx-auto" %}
{% endif %}
{% if position == "top" %}
{% assign positionClasses = "mb8 fd-column-reverse" %}
{% endif %}
Expand Down
14 changes: 7 additions & 7 deletions docs/product/foundation/accessibility.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
</button>
{% render 'example-row-detail.html',
text: group.description,
style: "margin-left: 50%;",
classes: "mx-auto",
customHeight: 16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: Looking at the example-row-detail.html partial I think that what we called customHeight in this file should be called connectorHeight instead.

Sidenote (out of scope)
I think we could find a better name for this partial. It took me a while to understand what Example Row Detail even mean and I still have some doubt. Perhaps something likeannotation.html or connected-annotation.html could work at least based on its usage here. Thoughts?

Copy link
Contributor Author

@dancormier dancormier Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: Looking at the example-row-detail.html partial I think that what we called customHeight in this file should be called connectorHeight instead.

Ah, nice catch! I've resolved this in this commit.

Sidenote (out of scope) I think we could find a better name for this partial. It took me a while to understand what Example Row Detail even mean and I still have some doubt. Perhaps something likeannotation.html or connected-annotation.html could work at least based on its usage here. Thoughts?

I agree. I think example-row-detail is one of those placeholder names that just accidentally became semi-permanent. I think annotation.html or example-annotation.html makes the sense to me (I'd argue against connected-annotation.html to keep the name tied to purpose as opposed to presentation).

I'll make a follow up PR for that to keep this PR focused. Thanks for the feedback.

Update: Here's the PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I have merged it now.
You might want to rebase this branch then. Hopefully there are not nasty conflicts to fix. 🤞

%}
</div>
Expand All @@ -135,7 +135,7 @@
</button>
{% render 'example-row-detail.html',
text: group.description,
style: "margin-left: 50%;",
classes: "mx-auto",
customHeight: 16
%}
</div>
Expand All @@ -160,7 +160,7 @@

{% render 'example-row-detail.html',
text: group.description,
style: "margin-left: 50%;",
classes: "mx-auto",
customHeight: 16
%}
</div>
Expand Down Expand Up @@ -199,7 +199,7 @@

{% render 'example-row-detail.html',
text: group.description,
style: "margin-left: 50%;",
classes: "mx-auto",
customHeight: 16
%}
</div>
Expand Down Expand Up @@ -234,7 +234,7 @@

{% render 'example-row-detail.html',
text: group.description,
style: "margin-left: 50%;",
classes: "mx-auto",
customHeight: 16
%}
</div>
Expand Down Expand Up @@ -286,7 +286,7 @@

{% render 'example-row-detail.html',
text: group.description,
style: "margin-left: 50%;",
classes: "mx-auto",
customHeight: 16
%}
</div>
Expand All @@ -308,7 +308,7 @@

{% render 'example-row-detail.html',
text: group.description,
style: "margin-left: 50%;",
classes: "mx-auto",
customHeight: 16
%}
</div>
Expand Down
14 changes: 8 additions & 6 deletions docs/product/foundation/color-fundamentals.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@
{% render 'example-row-detail.html',
text: "Input borders",
classes: "sm:d-none",
style: "margin-left: calc((1.5/11) * 100%);"
style: "margin-left: calc((1/11) * 100%); min-width: calc((1/11) * 100%)"
%}
</div>
</div>
Expand All @@ -195,8 +195,8 @@
%}
{% render 'example-row-detail.html',
text: "Heading",
style: "margin-left: calc((.5/11) * 100%);",
classes: "sm:d-none"
style: "min-width: calc((1/11) * 100%)",
classes: "sm:d-none fl-shrink1"
%}
</div>
</div>
Expand All @@ -212,12 +212,12 @@
<div class="d-flex w100">
{% render 'example-row-detail.html',
text: "Illustrations",
style: "margin-left: calc((7.5/11) * 100%)",
classes: "sm:d-none"
style: "margin-left: calc((7/11) * 100%); min-width: calc((1/11) * 100%)",
classes: "sm:d-none",
%}
{% render 'example-row-detail.html',
text: "Icons",
style: "margin-left: calc((.5/11) * 100%); width: calc((2/11) * 100%)",
style: "width: calc((2/11) * 100%)",
classes: "sm:d-none",
range: true
%}
Expand Down Expand Up @@ -344,6 +344,7 @@
<div class="fs-title {{group.textClasses}}">Text</div>
{% render 'example-row-detail.html',
text: group.name,
classes: "mx-auto",
style: "margin-left: 50%;"
%}
</div>
Expand All @@ -363,6 +364,7 @@
<button class="s-btn s-btn__filled {{group.classes}}" {{group.attr}} role="presentation">Button</button>
{% render 'example-row-detail.html',
text: group.name,
classes: "mx-auto",
style: "margin-left: 50%;"
%}
</div>
Expand Down
Loading