Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(fundamentals): rename example-row-detail to annotation #1863

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

dancormier
Copy link
Contributor

Relates to #1859 (comment)


This PR renames the docs include example-row-detail.html to annotation.html, making the purpose of the component much easier to understand just from the name.

@giamir I figured I'd make a PR just as a historical log and to provide space to debate the name if necessary. Feel free to merge if you think this is good to go.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for stacks failed. Why did it fail? →

Name Link
🔨 Latest commit 5cd3c1f
🔍 Latest deploy log https://app.netlify.com/sites/stacks/deploys/674637499f181000086c583a

Copy link
Contributor

@giamir giamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @dancormier. Thank you. 🙏

@giamir giamir merged commit 8b5a2e8 into develop Nov 27, 2024
7 of 11 checks passed
@giamir giamir deleted the dcormier/example-row-detail-rename-to-annotation branch November 27, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants