Stac 0 produce images #405
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on master, minor cleanups
# Conflicts: # .gitlab-ci-agent.yml # .gitlab-ci-cluster-agent.yml # Development.md # Dockerfiles/local_builder/Dockerfile
LouisParkin
approved these changes
Dec 15, 2021
Comment on lines
8
to
10
| ARG IBM_MQ_VERSION=9.1.5.0 | ||
| ARG IBM_MQ_VERSION=9.2.4.0 | ||
| ARG CMAKE_VERSION=3.14.4 | ||
| ARG CLANG_VERSION=8.0.0 |
There was a problem hiding this comment.
Now that I see this a second time in this review, I would offer the advice that we should probably not hard-code these in a Dockerfile, perhaps instead put it in gitlab-ci.yml file, or as gitlab environment variables. Doesn't have to happen today, but I think somebody should make a note (or a Jira ticket - Intermission perhaps).
There was a problem hiding this comment.
Such approach usually leads to situation, when you are unable to do anything locally, without knowing what is in external setup. So I would keep defaults in, as it is now.
There was a problem hiding this comment.
Thanks for the feedback, @LouisParkin !
Comment on lines
8
to
10
| # 9.1.0.9 | ||
| ARG IBM_MQ_VERSION=9.2.0.0 | ||
| ARG IBM_MQ_VERSION=9.2.4.0 | ||
| ARG CMAKE_VERSION=3.14.4 | ||
| ARG CLANG_VERSION=8.0.0 |
There was a problem hiding this comment.
Same comment as the other Dockerfiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1: Link to Jira issue
https://stackstate.atlassian.net/browse/STAC-15134
Step 2: Description of changes
.gitlab-ci-build-runners.ymlcreates a manual trigger onmasterpipelines.stackstate/stackstate-agent-runner-gitlab:deb7_20211210stackstate/stackstate-agent-runner-gitlab:centos7_20211210stackstate/stackstate-agent-runner-gitlab:deb-rpmpublisher_20211210Step 3: Did you add / update tests for your changes in the right area?
Step 4: I'm confident that everything is properly tested:
I got a PO / QA Approval by:
Step 5: Did you add release notes describing the changes you made?
Step 6: Can we ship this feature to production?