Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate design system from ENGAGE-HF #3

Merged
merged 10 commits into from
Oct 29, 2024
Merged

Conversation

arkadiuszbachorski
Copy link
Collaborator

Migrate design system from ENGAGE-HF

♻️ Current situation & Problem

ENGAGE-HF repository contains design system package. We aim to make it reusable across many different projects.

⚙️ Release Notes

  • Migrate design system from ENGAGE-HF packages
  • Update GitHub actions to configure publishing a package
  • Remove old Next-related dependencies, files, configurations

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link
Collaborator

@NikolaiMadlener NikolaiMadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @arkadiuszbachorski for the migration! Looks good to me.

.github/workflows/deployment.yml Show resolved Hide resolved
CONTRIBUTORS.md Show resolved Hide resolved
src/components/Avatar/Avatar.stories.tsx Show resolved Hide resolved
Copy link
Member

@PSchmiedmayer PSchmiedmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing; thanks for the first effort here @arkadiuszbachorski!

It would be great to get @NikolaiMadlener and @ThomasKaar 's input for this PR, feel free to merge it once you are aligned 🚀

Copy link
Collaborator

@NikolaiMadlener NikolaiMadlener left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨
Thanks @arkadiuszbachorski !

Copy link
Collaborator

@ThomasKaar ThomasKaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for migrating everything from the ENGAGE-HF project, @arkadiuszbachorski!!

Looks pretty good to me!

I just added some comments below, but nothing blocking from my side, since especially the splitting, can also be done in a future PR to speed up the process now

src/components/Avatar/Avatar.stories.tsx Show resolved Hide resolved
app/favicon.ico Outdated Show resolved Hide resolved
public/stanfordbiodesign.png Outdated Show resolved Hide resolved
src/modules/auth/SignInForm/SignInForm.tsx Outdated Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
@arkadiuszbachorski arkadiuszbachorski force-pushed the arek/migrate-design-system branch from f012342 to d39dee1 Compare October 28, 2024 08:13
Copy link

codecov bot commented Oct 29, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@PSchmiedmayer PSchmiedmayer merged commit 7e3bde0 into main Oct 29, 2024
7 of 9 checks passed
@PSchmiedmayer PSchmiedmayer deleted the arek/migrate-design-system branch October 29, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants