-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate design system from ENGAGE-HF #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @arkadiuszbachorski for the migration! Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing; thanks for the first effort here @arkadiuszbachorski!
It would be great to get @NikolaiMadlener and @ThomasKaar 's input for this PR, feel free to merge it once you are aligned 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✨
Thanks @arkadiuszbachorski !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for migrating everything from the ENGAGE-HF project, @arkadiuszbachorski!!
Looks pretty good to me!
I just added some comments below, but nothing blocking from my side, since especially the splitting, can also be done in a future PR to speed up the process now
f012342
to
d39dee1
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Migrate design system from ENGAGE-HF
♻️ Current situation & Problem
ENGAGE-HF repository contains design system package. We aim to make it reusable across many different projects.
⚙️ Release Notes
Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: