Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center isPending icon of Button #5

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

arkadiuszbachorski
Copy link
Collaborator

Center isPending icon of Button

♻️ Current situation & Problem

Pending button icon is not vertically centered.

⚙️ Release Notes

  • Center icon of pending Button

✅ Testing

Fixed isPending state:
image

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Nov 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.86%. Comparing base (64a4b31) to head (9cbfb44).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   77.89%   77.86%   -0.02%     
==========================================
  Files         124      124              
  Lines        2591     2588       -3     
  Branches      266      266              
==========================================
- Hits         2018     2015       -3     
  Misses        547      547              
  Partials       26       26              
Files with missing lines Coverage Δ
src/components/Button/ButtonPending.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a4b31...9cbfb44. Read the comment docs.

Copy link
Collaborator

@ThomasKaar ThomasKaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkadiuszbachorski arkadiuszbachorski force-pushed the arek/center-pending-button branch from ff18948 to dfc5e9d Compare November 4, 2024 22:02
@arkadiuszbachorski arkadiuszbachorski force-pushed the arek/center-pending-button branch from dfc5e9d to 9cbfb44 Compare November 4, 2024 22:05
@arkadiuszbachorski arkadiuszbachorski merged commit 42275a4 into main Nov 4, 2024
9 checks passed
@arkadiuszbachorski arkadiuszbachorski deleted the arek/center-pending-button branch November 4, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants