Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix spill merge options in various key type/order by/merge condition configs #54862

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

decster
Copy link
Contributor

@decster decster commented Jan 9, 2025

Why I'm doing:

What I'm doing:

  • spill merge cannot be applied when having merge conditions, so disable it if merge_condition is not empty
  • aggregate/unique key table can do aggregation when do merge, so enable it
  • duplicate key do not need aggregation
  • primary key may do/not do aggregation in normal cases, but when order key is different from primary key, should not do aggregation, so just don't do aggregation.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@decster decster requested a review from a team as a code owner January 9, 2025 05:50
@mergify mergify bot assigned decster Jan 9, 2025
@decster decster force-pushed the fix-spill-merge-in-various-key-types branch from 7c1f867 to 53f5ad6 Compare January 9, 2025 07:58
Copy link

github-actions bot commented Jan 9, 2025

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Jan 9, 2025

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

github-actions bot commented Jan 9, 2025

[BE Incremental Coverage Report]

pass : 4 / 4 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/lake/spill_mem_table_sink.cpp 3 3 100.00% []
🔵 be/src/storage/lake/delta_writer.cpp 1 1 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant