Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tool] support build maven project in batch mode #54940

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevincai
Copy link
Contributor

  • suppress maven download log

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@kevincai kevincai requested a review from a team as a code owner January 10, 2025 08:13
cd ${STARROCKS_HOME}/java-extensions
${MVN_CMD} package -am -pl hadoop-ext -DskipTests
${MVN_CMD} $addon_mvn_opts package -am -pl hadoop-ext -DskipTests
cd ${STARROCKS_HOME}
fi

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most risky bug in this code is:
The script assumes that the tty command will be available and correctly determine if the shell is non-interactive, which might not always be reliable across different environments or systems.

You can modify the code like this:

# Ensure that tty check is robust and add a fallback mechanism
WITH_MAVEN_BATCH_MODE=OFF

if [ -x "$(command -v tty)" ]; then
    if ! tty -s >/dev/null 2>&1; then
        WITH_MAVEN_BATCH_MODE=ON
    fi
else
    # Fallback to a default behavior when tty command is not present
    case $- in
        *i*) ;;
          *) WITH_MAVEN_BATCH_MODE=ON ;;
    esac
fi

This modification ensures the script properly handles systems where tty might not be available and provides a fallback check using shell options.

* suppress maven download log

Signed-off-by: Kevin Xiaohua Cai <[email protected]>
@kevincai kevincai force-pushed the mvn-batch-mode-support branch from 67cbc83 to 21627ab Compare January 10, 2025 08:41
Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant