Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]define GlobalDictNotMatch Status and extract info to feedback #54945

Merged
merged 3 commits into from
Jan 14, 2025

Conversation

zombee0
Copy link
Contributor

@zombee0 zombee0 commented Jan 10, 2025

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@zombee0 zombee0 requested a review from a team as a code owner January 10, 2025 08:45
@wanpengfei-git wanpengfei-git requested a review from a team January 10, 2025 08:46
@zombee0 zombee0 force-pushed the global_dict_not_match branch from f8f7416 to dc25d1f Compare January 10, 2025 11:32
@zombee0 zombee0 requested a review from a team as a code owner January 10, 2025 12:08
@zombee0 zombee0 force-pushed the global_dict_not_match branch from 6c4c878 to 7d303a7 Compare January 13, 2025 03:30
Copy link

[BE Incremental Coverage Report]

pass : 2 / 2 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/common/status.cpp 2 2 100.00% []

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

fail : 14 / 18 (77.78%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/connector/exception/GlobalDictNotMatchException.java 13 17 76.47% [47, 51, 52, 53]
🔵 com/starrocks/common/Status.java 1 1 100.00% []

@DorianZheng DorianZheng enabled auto-merge (squash) January 14, 2025 02:10
@andyziye andyziye disabled auto-merge January 14, 2025 02:23
@andyziye andyziye merged commit 49699c2 into StarRocks:main Jan 14, 2025
52 of 55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants