Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] enhance delete pruning for all kinds of partitions (backport #55400) #55464

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 26, 2025

Why I'm doing:

What I'm doing:

Currently DELETE cannot do partition pruning for LIST PARTITION, which will affect many aspects, like statistics collection and materialized view refresh.

To address this issue we'd better leveraging the optimizer to do this work.

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Copy link
Contributor Author

mergify bot commented Jan 26, 2025

Cherry-pick of 4ae63bd has failed:

On branch mergify/bp/branch-3.3/pr-55400
Your branch is up to date with 'origin/branch-3.3'.

You are currently cherry-picking commit 4ae63bdce7.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   fe/fe-core/src/main/java/com/starrocks/load/DeleteMgr.java

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   fe/fe-core/src/test/java/com/starrocks/load/DeletePruneTest.java

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented Jan 26, 2025

@mergify[bot]: Backport conflict, please reslove the conflict and resubmit the pr

auto-merge was automatically disabled January 26, 2025 12:38

Pull request was closed

@murphyatwork murphyatwork reopened this Jan 27, 2025
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) January 27, 2025 01:26
)

Signed-off-by: Murphy <mofei@starrocks.com>
(cherry picked from commit 4ae63bd)
Signed-off-by: Murphy <mofei@starrocks.com>

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/load/DeletePruneTest.java
@murphyatwork murphyatwork force-pushed the mergify/bp/branch-3.3/pr-55400 branch from 00f4708 to 439a26c Compare January 27, 2025 01:33
@wanpengfei-git wanpengfei-git merged commit 7e755f3 into branch-3.3 Jan 27, 2025
31 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-55400 branch January 27, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants