Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Stream load/routine support load channel profile #55490

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

banmoy
Copy link
Contributor

@banmoy banmoy commented Jan 27, 2025

Why I'm doing:

The previous pr #41664 adds load channel profile, but it only supports broker load/insert which use pipeline engine. stream load/routine load are still using non-pipeline engine, so we can't get load channel profile for stream load/routine load

What I'm doing:

support to get load channel profile for stream load/routine

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@banmoy banmoy requested review from a team as code owners January 27, 2025 05:35
@mergify mergify bot assigned banmoy Jan 27, 2025
@github-actions github-actions bot added the 3.4 label Jan 27, 2025
@banmoy banmoy changed the title [Enhancement] stream load/routine load supports load channel profile [Enhancement] support to get load channel profile for stream load/routine Jan 27, 2025
@banmoy banmoy changed the title [Enhancement] support to get load channel profile for stream load/routine [Enhancement] Support load channel profile for stream load/routine Jan 27, 2025
@banmoy banmoy changed the title [Enhancement] Support load channel profile for stream load/routine [Enhancement] Stream load/routine support load channel profile Jan 27, 2025
@banmoy banmoy force-pushed the stream_load_profile branch from e8769be to 4c0d1e5 Compare January 27, 2025 05:47
Signed-off-by: PengFei Li <[email protected]>
@banmoy banmoy force-pushed the stream_load_profile branch from ca6182e to ef64f68 Compare January 27, 2025 11:09
Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

pass : 19 / 21 (90.48%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/load/streamload/StreamLoadTask.java 0 1 00.00% [1110]
🔵 com/starrocks/qe/scheduler/QueryRuntimeProfile.java 14 15 93.33% [628]
🔵 com/starrocks/qe/scheduler/dag/JobSpec.java 5 5 100.00% []

Copy link

[BE Incremental Coverage Report]

pass : 14 / 14 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/exec/tablet_sink.cpp 7 7 100.00% []
🔵 be/src/runtime/plan_fragment_executor.cpp 1 1 100.00% []
🔵 be/src/runtime/fragment_mgr.cpp 6 6 100.00% []

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant