Skip to content

Commit

Permalink
feat(ci): remove ml-pipelines rolebinding
Browse files Browse the repository at this point in the history
  • Loading branch information
Souheil-Yazji committed Nov 30, 2022
1 parent 3dc1ce4 commit 90dc5d9
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 25 deletions.
1 change: 1 addition & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ on:
push:
branches:
- main
- feat-remote-pipeline

# Environment variables available to all jobs and steps in this workflow
env:
Expand Down
25 changes: 0 additions & 25 deletions cmd/rbac.go
Original file line number Diff line number Diff line change
Expand Up @@ -187,31 +187,6 @@ func generateRoles(profile *kubeflowv1.Profile) []*rbacv1.Role {
func generateRoleBindings(profile *kubeflowv1.Profile) []*rbacv1.RoleBinding {
roleBindings := []*rbacv1.RoleBinding{}

// Grant every profile a ml-pipeline role binding
roleBinding := &rbacv1.RoleBinding{
ObjectMeta: metav1.ObjectMeta{
Name: "ml-pipeline",
Namespace: profile.Name,
OwnerReferences: []metav1.OwnerReference{
*metav1.NewControllerRef(profile, kubeflowv1.SchemeGroupVersion.WithKind("Profile")),
},
},
RoleRef: rbacv1.RoleRef{
APIGroup: rbacv1.SchemeGroupVersion.Group,
Kind: "ClusterRole",
Name: "ml-pipeline",
},
Subjects: []rbacv1.Subject{
{
APIGroup: "rbac.authorization.k8s.io",
Kind: "User",
Name: profile.Spec.Owner.Name,
},
},
}

roleBindings = append(roleBindings, roleBinding)

// DAaaS-AAW-Support is granted "profile-support" cluster role in this namespace
if len(rbacSupportGroups) > 0 {
roleBinding := &rbacv1.RoleBinding{
Expand Down

0 comments on commit 90dc5d9

Please sign in to comment.