Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Pipelines - from DEV #1449

Closed
5 tasks done
Tracked by #1444
wg102 opened this issue Nov 23, 2022 · 11 comments
Closed
5 tasks done
Tracked by #1444

Remove Pipelines - from DEV #1449

wg102 opened this issue Nov 23, 2022 · 11 comments
Assignees

Comments

@wg102
Copy link
Contributor

wg102 commented Nov 23, 2022

This is to deprecated Kubeflow-Pipelines features.

It might include multiple steps.

** Update **
For easy tracking, a new ticket was created for testing purposes.

  • Test dev
  • Execute the plan for prod
  • Clean up the leftover resources (config maps, secrets, deployments , svc, service account, rolebindings)
@wg102
Copy link
Contributor Author

wg102 commented Nov 29, 2022

Following the deletions, it was noticed that a few pods, and different types of resources are not deleted. I will try to manually delete them to see if they recreated. I am not sure why it happened, but it will most likely be similar on Prod.

@wg102
Copy link
Contributor Author

wg102 commented Nov 29, 2022

This was not completed on time yesterday because of the network issues, it took minutes to query simple resources making the debugging virtually impossible.

@Souheil-Yazji Souheil-Yazji self-assigned this Nov 30, 2022
@wg102
Copy link
Contributor Author

wg102 commented Nov 30, 2022

There is one additional issue, in Dev when opening the dev tools I see the 2 following error message:
image

@wg102
Copy link
Contributor Author

wg102 commented Nov 30, 2022

Needed to delete the services, that automatically deleted the secrets.
Rolebindings and serviceaccounts get recreated as soon as they are deleted.

wg102 pushed a commit to StatCan/aaw-kubeflow-profiles-controller that referenced this issue Nov 30, 2022
wg102 added a commit to StatCan/charts that referenced this issue Nov 30, 2022
wg102 added a commit to StatCan/charts that referenced this issue Nov 30, 2022
wg102 added a commit to StatCan/charts that referenced this issue Nov 30, 2022
Part of StatCan/aaw#1449

I think the sha was update after the last version bump
@Souheil-Yazji
Copy link
Contributor

Removed ml-pipelines rolebinding creation from aaw-kubeflow-profiles-controller. Redeployed controller to dev.

@wg102
Copy link
Contributor Author

wg102 commented Dec 1, 2022

The role bindings delete after the update in charts/argocd-manifest

@wg102
Copy link
Contributor Author

wg102 commented Dec 1, 2022

We have all the changes required to remove pipelines, but it will most likely still need manual deletion of resources on prod. It might be possible to create a script to run it instead.

@wg102
Copy link
Contributor Author

wg102 commented Dec 6, 2022

I am missing changes on the Kubeflow repo, to remove the cards about the pipelines.

Once the changes are done, cleanup will be needed. As far as I currently see on prod:

  • Configmaps: 11
  • Secrets 134
  • Svc: 251
  • Serviceaccount: Access denied
  • Deployments: 15 (or 7... depending how you read it)
  • Rolebindings: Access denied

@wg102
Copy link
Contributor Author

wg102 commented Dec 6, 2022

Converted the prod PRs to draft, while waiting for answers from the kubeflow folks. Also, we need to establish a testing plan for dev, to make sure there is nothing wrong with the way we removed the pipelines.

@StanHatko
Copy link
Contributor

I documented this in the pull request for the AAW user documentation #1470, where I said pipelines are in the process of being removed.

@wg102 wg102 changed the title Remove Pipelines Remove Pipelines - from DEV Dec 14, 2022
@wg102 wg102 mentioned this issue Dec 14, 2022
23 tasks
@wg102
Copy link
Contributor Author

wg102 commented Dec 14, 2022

This will need to be tested in the #1472

@wg102 wg102 closed this as completed Dec 14, 2022
@wg102 wg102 mentioned this issue Jan 11, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants