Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for custom compression options #21

Merged
merged 5 commits into from
Oct 13, 2024

Conversation

eXhumer
Copy link
Contributor

@eXhumer eXhumer commented Oct 5, 2024

Adds option to use deflate as compression algo for ZIP instead of store (used by default). Also, allows specifying the compression level for deflate compression.

CI updated to use actions/download-artifact@4 & actions/upload-artifact@4 to fix issue with last CI build.

@eXhumer
Copy link
Contributor Author

eXhumer commented Oct 5, 2024

Updated commit to default to method deflate and compression level to level 9 if no options specified. This will make resulting ZIP significantly smaller at slight cost of ZIP time.

@eXhumer
Copy link
Contributor Author

eXhumer commented Oct 5, 2024

This should also close #19.

@TrainDoctor TrainDoctor requested a review from SkyLeite October 13, 2024 17:47
@TrainDoctor TrainDoctor added the enhancement New feature or request label Oct 13, 2024
Copy link
Collaborator

@SkyLeite SkyLeite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the contribution ❤️ ✨

@SkyLeite SkyLeite merged commit ff389ae into SteamDeckHomebrew:main Oct 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants