Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aberration for the Milky Way lost? #4099

Closed
Atque opened this issue Jan 24, 2025 · 1 comment · Fixed by #4102
Closed

Aberration for the Milky Way lost? #4099

Atque opened this issue Jan 24, 2025 · 1 comment · Fixed by #4102
Assignees
@henrysky
Labels
importance: high Obvious error, very annoying, but no crash
Milestone
25.1

Comments

@Atque
Copy link
Contributor

Atque commented Jan 24, 2025

Using the current master, I can't get Milky Way to show aberration correction. It works on the stable 24.4.

I tried standing on Mercury with aberration set to maximum value (5x exaggeration), and letting time flow. Milky Way is stationary, while DSO textures and stars move according to different speeds and directions of the Mercurian movement.

System: Windows 10, 64-bit
Built with Qt 6.7.1.
@gzotti gzotti added this to the 25.1 milestone Jan 24, 2025
@gzotti gzotti added the importance: high Obvious error, very annoying, but no crash label Jan 24, 2025
@henrysky
Copy link
Contributor

henrysky commented Jan 24, 2025 •
edited
Loading

stellarium/src/core/StelCore.cpp

Line 3179 in eef23d8

velocity = cachedAberrationVec;

My bad, I did not take aberration factor into account when I modified that line (looks like stationary because everything has 5x abberation but the milkyway has 1x abberation). Should be velocity = getAberrationFactor() * cachedAberrationVec;

@henrysky henrysky mentioned this issue Jan 25, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henrysky henrysky

Labels
importance: high Obvious error, very annoying, but no crash
Milestone
25.1
Development

Successfully merging a pull request may close this issue.

Fix aberration factor not taken into account for milkyway texture henrysky/stellarium
3 participants
@gzotti @henrysky @Atque