Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aberration factor not taken into account for milkyway texture #4102

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

henrysky
Copy link
Contributor

Fix aberration factor not taken into account for milkyway texture.

Fixes #4099

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Visually, go to Mercury and set aberration to x5.0 and then toggle on and off to check how the milkyway texture move compared to stars.

Test Configuration:

  • Operating system: MacOS 15.2
  • Graphics Card: Apple M3

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@henrysky henrysky marked this pull request as ready for review January 25, 2025 00:30
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

@alex-w alex-w added this to the 25.1 milestone Jan 25, 2025
Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alex-w alex-w merged commit c054b2c into Stellarium:master Jan 25, 2025
17 checks passed
@10110111
Copy link
Contributor

Not sure if this is related, but I get the following warning since your huge change to support Gaia-enabled catalog.

/home/ruslan/src/stellarium/src/core/modules/SolarSystem.cpp: In member function ‘virtual QList<QSharedPointerNoDelete<StelObject> > SolarSystem::searchAround(const Vec3d&, double, const StelCore*) const’:
/home/ruslan/src/stellarium/src/core/modules/SolarSystem.cpp:2522:20: warning: unused variable ‘withAberration’ [-Wunused-variable]
 2522 |         const bool withAberration=core->getUseAberration();
      |                    ^~~~~~~~~~~~~~

@alex-w
Copy link
Member

alex-w commented Jan 25, 2025

This variable isn't used anymore in these method, so, I removed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Aberration for the Milky Way lost?
3 participants