-
-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all splash screen text scalable #4092
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
What if you specify "Bitstream Vera Sans" explicitly? (And I wonder what will happen on Windows then.) |
c70a678
to
cd5a8ed
Compare
Please retry with the updated version. |
76fed07
to
f363f45
Compare
The look is much better, but why not using "DejaVu Sans" for text on splash? We distribute this font with Stellarium and it give best look for density of text IMHO. |
Well, first of all, I didn't know that we distribute some fonts. Second, it appears that the alignment of the title and subtitle with DejaVu Sans is broken :\ BTW, there are several instances of DejaVu Sans in the tree, and all are different, is it intended?
|
f363f45
to
925e574
Compare
So, now it should be pixel-perfect in the sense that the rightmost pixels of all three text lines must be at the same column. This might be a bit suboptimal regarding very faint sides of vertical lines (where the better alignment would be by the neighboring bright column), but it's OK to me. Here's how it looks on my Ubuntu 20.04: If it looks similarly good on Windows and the Linux distro used by @alex-w, this can be merged. |
This is may be strange, but what about some redesign the splash screen - version 25.1 will coming with serious changes and we can make a "Stellarium" text a bit less and add the version number in same string (e.g. "Stellarium 25.0" currently) + do a small shift of both lines (Stellarium & stellarium.org) to up. @10110111 @gzotti @sushoff @henrysky @worachate001 your opinion? |
We doing it since version 10.1/10.2 (at least in 10.5 when I coming in the project the DejaVu fonts already was in distributive of Stellarium).
This is sad, but probably our fonts is outdated now.
This is font which we distribute within Stellarium by default
We distribute it too, but for Remote Control plugin only (a font is using for compatibility of text rendering within WUI) - probably we should sync the font with main one.
This is font for utilite and he is outdated by the fact now and we do not distribute it within binary packages. |
I'm not sure it would look better. The current version placement looks nice to me, while simply having it follow the name would be somewhat boring, too standard. But anyway, this is something a designer should look at. From readability perspective we shouldn't lift the text too much up, otherwise it would be white on white. |
"Stellarium:25.0" :-) ? P.S. The current look is OK for me, but maybe someone want to see a some changes P.P.S. @10110111 is it possible to make a splash screen a grayscale in depending by config option? In this case we shouldn't be storing 2 images and we can avoid a cache issue. |
The look of text is perfect for me |
make a "Stellarium" text a bit less and add the version number in same
string
I'm not sure it would look better. The current version placement looks
nice to me, while simply having it follow the name would be somewhat
boring, too standard. But anyway, this is something a designer should look
at. From readability perspective we shouldn't lift the text too much up,
otherwise it would be white on white.
"Stellarium:25.0" :-) ?
I don't like this, the colon doesn't make sense.
@10110111 <https://github.com/10110111> is it possible to make a splash
screen a grayscale in depending by config option? In this case we shouldn't
be storing 2 images and we can avoid a cache issue.
What kind of cache? I wanted, to the contrary, to provide multiple images
optimally looking at different scales (dithered to avoid banding, and this
is lost on resampling). Otherwise we'd have to resize and dither a large
16-bpc source image at runtime, which may add a delay before the appearance
of the splash.
|
So, the PR can be merge as is :) |
Currently the splash screen has rasterized branding text:
Stellarium
andstellarium.org
. This text gets upscaled when scale factor or font size changes. It's better to have it rendered as text instead, which this PR does.Later I intend to also provide a higher-resolution version of the background image.
Now, it looks as intended on Ubuntu 20.04, but I'm not completely sure how this will look on Windows, because
Sans
font will be different there. Please show me your screenshots from Windows before this could be mergeable.This is how it looks on Ubuntu 20.04. To compare just try upscaling the current splash or run Stellarium with 26px GUI fonts or 200% scaling.