Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combination of work for Rails8 support #3

Merged
merged 8 commits into from
Dec 31, 2024

Conversation

formigarafa
Copy link

Hello there,

I went through rgeo#419 and rgeo#421 to make this PR.
I have then

  • merged them with master
  • excluded one test from activerecord that would not pass because of a Postgis related constraint that is interfering with an expectation due to the way it was coded.
  • dismissed a change to AR_VERSION env variable on github workflow which is not needed. There is code to pick the right version from the installed gems on test/rake_helper.rb

dorner and others added 8 commits November 5, 2024 16:26
Fix loading issue with rake db:create on Rails 7.2
schema dump is working fine.
postgis just adds another foreign key entry in the dump within the boundary active records spec uses
in the regex to test their case but the actual test would still be valid.
added entry:
```
add_foreign_key "layer", "topology", name: "layer_topology_id_fkey"
```
@formigarafa
Copy link
Author

formigarafa commented Dec 30, 2024

A PR with same codebase on my fork have the tests passing: formigarafa#2

@StoneGod StoneGod merged commit 147fd43 into StoneGod:rails-8 Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants