Floating point image support. #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everything but FP gamma correction has been supported. Needs extensive testing, basic testing tells to and from 32/16fp works flawlessly. |
|
Also fixed a memory leak in the original Create() function related to resize which coincidentally altered the original image data rather than copying, which resulted in the original image data losing track of it's actual size. |
|
I have made the mistake of leaving clang-format on when making the PR, I apologize to the reviewers. |
Trico-Everfire
force-pushed
the
feat/floating_point_support
branch
from
a0e35d1 to
6aab315
Compare
|
This PR is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've worked the better part of a week adding floating point image support (RGB(A)FP32/RGBAFP16) to VTFLib, currently, there are some criteria missing, as well as proper cleanup/making sure no memory leaks occur. (I am sure there are some as of writing this) and would love to have some feedback.
roadmap: