Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling room events and IO connections #195

Merged
merged 10 commits into from
Jan 3, 2025

Conversation

carlossantos74
Copy link
Contributor

@carlossantos74 carlossantos74 commented Jan 2, 2025

Improvements to Room class and related types:

  • Updated Participant type to include slot and activeComponents properties, and introduced InitialParticipant and Slot types.
  • Enhanced the Room class with methods for subscribing and unsubscribing to events, handling participant and room events, and managing connection state changes.
  • Added comprehensive tests for the Room class to cover room creation, event handling, and error scenarios.

Type and schema updates:

  • Updated RoomParams to use InitialParticipant and added types for room events and their payloads.
  • Exported Room, Participant, RoomEvent, ParticipantEvent, and Callback types from the room package.

Copy link

github-actions bot commented Jan 2, 2025

test: Run #270

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
71 71 0 0 0 0 0 8.0s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 2, 2025

test: Run #270

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
13 13 0 0 0 0 0 7.7s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 2, 2025

test: Run #270

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
135 135 0 0 0 0 0 10.0s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 2, 2025

test: Run #270

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
746 746 0 0 0 0 0 22.8s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 2, 2025

LCOV Report - SDK Web Components Test Coverage Report ✅

All Files

  • Lines: 6230/6424 (97.0%) ✅ (Minimum coverage is 0%)
  • Functions: 304/319 (95.3%)
  • Branches: 610/693 (88.0%)

Changed Files

N/A

@carlossantos74 carlossantos74 force-pushed the feat/new-room-oackage-params branch from ba98516 to 1625cfd Compare January 3, 2025 15:03
Copy link

github-actions bot commented Jan 3, 2025

test: Run #272

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
71 71 0 0 0 0 0 7.9s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 3, 2025

test: Run #272

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
135 135 0 0 0 0 0 9.8s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 3, 2025

test: Run #272

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
24 24 0 0 0 0 0 8.5s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 3, 2025

test: Run #272

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
746 746 0 0 0 0 0 23.0s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 3, 2025

test: Run #273

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
71 71 0 0 0 0 0 8.1s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 3, 2025

test: Run #273

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
135 135 0 0 0 0 0 10.1s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 3, 2025

test: Run #273

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
24 24 0 0 0 0 0 8.5s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 3, 2025

test: Run #273

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
746 746 0 0 0 0 0 23.7s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 3, 2025

test: Run #274

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
27 26 1 0 0 0 0 8.3s

Some tests failed!

Name Failure Message
❌ Room should handle participant joined room event Error: expect(jest.fn()).toHaveBeenCalledWith(...expected)

Expected: "participant.joined", {"activeComponents": [], "id": "123", "name": undefined, "slot": {"color": "#878291", "colorName": "gray", "index": null, "textColor": "#fff", "timestamp": 1735924851229}}
Received
1
"my-participant.joined",
@@ -5,8 +5,8 @@
"slot": Object {
"color": "#878291",
"colorName": "gray",
"index": null,
"textColor": "#fff",
- "timestamp": 1735924851229,
+ "timestamp": 1735924851230,
},
},
2
"participant.joined",
@@ -5,8 +5,8 @@
"slot": Object {
"color": "#878291",
"colorName": "gray",
"index": null,
"textColor": "#fff",
- "timestamp": 1735924851229,
+ "timestamp": 1735924851230,
},
},

Number of calls: 2

Copy link

github-actions bot commented Jan 3, 2025

test: Run #274

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
71 71 0 0 0 0 0 8.1s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 3, 2025

test: Run #274

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
135 135 0 0 0 0 0 10.0s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 3, 2025

test: Run #274

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
746 746 0 0 0 0 0 22.6s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 3, 2025

test: Run #274

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
27 27 0 0 0 0 0 8.3s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 3, 2025

test: Run #274

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
135 135 0 0 0 0 0 10.1s

🎉 All tests passed!

@carlossantos74 carlossantos74 marked this pull request as ready for review January 3, 2025 17:24
Copy link

github-actions bot commented Jan 3, 2025

test: Run #274

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
746 746 0 0 0 0 0 22.7s

🎉 All tests passed!

@carlossantos74 carlossantos74 merged commit 5c64f18 into lab Jan 3, 2025
6 checks passed
@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/socket-client/1.15.0-lab.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/sdk/6.9.0-lab.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/yjs/1.1.0-lab.2 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/react/1.16.0-lab.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/autodesk/1.23.0-lab.2 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/matterport/1.3.0-lab.2 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/three/1.3.0-lab.2 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/socket-client/1.15.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/sdk/6.9.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/yjs/1.1.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/autodesk/1.23.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/matterport/1.3.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/three/1.3.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/react/1.16.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/socket-client/1.15.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/sdk/6.9.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/yjs/1.1.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/autodesk/1.23.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/matterport/1.3.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/three/1.3.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/react/1.16.0 🎉

The release is available on GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants