-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(YJS|SDK): remove unnecessary validation from components initialization #201
Conversation
test: Run #285
🎉 All tests passed! |
test: Run #285
🎉 All tests passed! |
test: Run #285
🎉 All tests passed! |
test: Run #285
🎉 All tests passed! |
LCOV Report - SDK Web Components Test Coverage Report ✅All Files
Changed FilesN/A |
🎉 This issue has been resolved in version @superviz/socket-client/1.15.0-lab.7 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/sdk/6.9.0-lab.1 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/yjs/1.1.0-lab.2 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/react/1.16.0-lab.1 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/autodesk/1.23.0-lab.2 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/matterport/1.3.0-lab.2 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/three/1.3.0-lab.2 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/socket-client/1.15.0-beta.1 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/sdk/6.9.0-beta.1 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/yjs/1.1.0-beta.1 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/autodesk/1.23.0-beta.1 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/matterport/1.3.0-beta.1 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/three/1.3.0-beta.1 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/react/1.16.0-beta.1 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/socket-client/1.15.0 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/sdk/6.9.0 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/yjs/1.1.0 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/autodesk/1.23.0 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/matterport/1.3.0 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/three/1.3.0 🎉 The release is available on GitHub release |
🎉 This issue has been resolved in version @superviz/react/1.16.0 🎉 The release is available on GitHub release |
This pull request removes the domain whitelisting feature from the SDK. The most important changes include the removal of the
isDomainWhitelisted
property and associated logic from various components and tests.Removal of domain whitelisting feature:
packages/sdk/src/components/base/index.ts
: Removed the check forisDomainWhitelisted
and the associated log message.packages/sdk/src/core/launcher/index.ts
: Removed theisDomainWhitelisted
property and its subscription in theLauncher
class.packages/sdk/src/services/stores/global/index.ts
: Removed theisDomainWhitelisted
property and its destruction in theGlobalStore
class. [1] [2] [3]packages/yjs/src/provider/index.test.ts
: Removed tests related to theisDomainWhitelisted
property. [1] [2]packages/yjs/src/provider/index.ts
: Removed the check forisDomainWhitelisted
and the associated log message in theSuperVizYjsProvider
class.