Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(YJS|SDK): remove unnecessary validation from components initialization #201

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

carlossantos74
Copy link
Contributor

@carlossantos74 carlossantos74 commented Jan 7, 2025

This pull request removes the domain whitelisting feature from the SDK. The most important changes include the removal of the isDomainWhitelisted property and associated logic from various components and tests.

Removal of domain whitelisting feature:

Copy link

github-actions bot commented Jan 7, 2025

test: Run #285

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
135 135 0 0 0 0 0 9.7s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 7, 2025

test: Run #285

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
47 47 0 0 0 0 0 9.4s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 7, 2025

test: Run #285

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
70 70 0 0 0 0 0 8.4s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 7, 2025

test: Run #285

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Pending ⏳ Other ❓ Flaky 🍂 Duration ⏱️
746 746 0 0 0 0 0 22.3s

🎉 All tests passed!

Copy link

github-actions bot commented Jan 7, 2025

LCOV Report - SDK Web Components Test Coverage Report ✅

All Files

  • Lines: 6230/6424 (97.0%) ✅ (Minimum coverage is 0%)
  • Functions: 304/319 (95.3%)
  • Branches: 610/693 (88.0%)

Changed Files

N/A

@carlossantos74 carlossantos74 merged commit f15aace into lab Jan 7, 2025
6 checks passed
@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/socket-client/1.15.0-lab.7 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/sdk/6.9.0-lab.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/yjs/1.1.0-lab.2 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/react/1.16.0-lab.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/autodesk/1.23.0-lab.2 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/matterport/1.3.0-lab.2 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/three/1.3.0-lab.2 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/socket-client/1.15.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/sdk/6.9.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/yjs/1.1.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/autodesk/1.23.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/matterport/1.3.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/three/1.3.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/react/1.16.0-beta.1 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/socket-client/1.15.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/sdk/6.9.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/yjs/1.1.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/autodesk/1.23.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/matterport/1.3.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/three/1.3.0 🎉

The release is available on GitHub release

@SuperViz-Dev
Copy link
Contributor

🎉 This issue has been resolved in version @superviz/react/1.16.0 🎉

The release is available on GitHub release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants