Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(service): improve api docs #2103

Merged
merged 7 commits into from
May 31, 2021
Merged

chore(service): improve api docs #2103

merged 7 commits into from
May 31, 2021

Conversation

rokroskar
Copy link
Member

@rokroskar rokroskar commented May 20, 2021

This PR fills in several of the API docstrings to add missing schemas. It also adds a description of the API including the response codes.

closes #2056

/deploy #notest

@rokroskar rokroskar changed the title 2056 api docs chore: improve api docs May 20, 2021
@rokroskar rokroskar changed the title chore: improve api docs chore(service): improve api docs May 20, 2021
@rokroskar rokroskar temporarily deployed to renku-ci-rp-2103 May 20, 2021 17:14 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-rp-2103.dev.renku.ch

@rokroskar rokroskar marked this pull request as ready for review May 21, 2021 16:01
@rokroskar rokroskar requested a review from a team as a code owner May 21, 2021 16:01
@rokroskar rokroskar temporarily deployed to renku-ci-rp-2103 May 21, 2021 16:12 Inactive
@rokroskar
Copy link
Member Author

I've removed the bit that added the api spec to the sphinx docs - it was not working properly (see e.g. sphinx-contrib/openapi#88 and sphinx-contrib/openapi#107) and caused build warnings which in turn made the docs CI fail.

@rokroskar rokroskar temporarily deployed to renku-ci-rp-2103 May 25, 2021 14:32 Inactive
@rokroskar rokroskar deployed to renku-ci-rp-2103 May 26, 2021 15:19 Active
@rokroskar
Copy link
Member Author

As agreed this morning, I added a stub for the service sphinx docs.

Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rokroskar rokroskar merged commit 058200a into master May 31, 2021
@rokroskar rokroskar deleted the 2056-api-docs branch May 31, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the API documentation
3 participants