Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task/WG-197: improve linting on react project #188

Merged
merged 8 commits into from
Dec 22, 2023
Merged

task/WG-197: improve linting on react project #188

merged 8 commits into from
Dec 22, 2023

Conversation

nathanfranklin
Copy link
Collaborator

@nathanfranklin nathanfranklin commented Dec 22, 2023 •
edited
Loading

Overview:

Improve linting:

  • updated linting rules
  • made some minor fixes of existing code
  • added eslintignore

PR Status:

  • Ready.

Related Jira tickets:

Testing Steps:

  1. Just see output on CI

sophia-massie
sophia-massie approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Didn't run it but checked the out CI.

tjgrafft
tjgrafft approved these changes Dec 22, 2023
View reviewed changes
Copy link
Contributor

@tjgrafft tjgrafft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output on CI LGTM

@nathanfranklin nathanfranklin merged commit ee0f7d3 into master Dec 22, 2023
5 checks passed
@nathanfranklin nathanfranklin deleted the task/WG-197-improve-linting-on-react-project branch December 22, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgrafft tjgrafft tjgrafft approved these changes

@sophia-massie sophia-massie sophia-massie approved these changes

@taoteg taoteg Awaiting requested review from taoteg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nathanfranklin @tjgrafft @sophia-massie