Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/WG 411 Questionnaire Modal #306

Merged
merged 7 commits into from
Jan 24, 2025

Conversation

sophia-massie
Copy link
Contributor

@sophia-massie sophia-massie commented Jan 23, 2025

Overview:

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

  1. Installed @types/jquery and jquery for questionnaire builder
  2. Add hooks to mimic angular services to pass the path and json to the questionnaire builder
  3. Add questionnaire builder lifted from angular. Changes from angular:
  • Had to comment out properties of subclasses because the way node handles inheritance is different. It was overwriting the parent class properties.
  • Imported uuid differently because we're using a different updated version
  • Imported jquery as default
  1. Add questionnaire component
  2. Lifted styles from angular with some additions
  3. Added onClick function for AssetButton to open the questionnaire modal
  4. Added questionnaire modal component to MapProject
  5. Added on prop to AssetDetail to pass back from the Asset button to the MapProject to toggle the modal
  6. Changed z-index of assetdetail and menu panel to no be on some plane as modal

Testing Steps:

  1. Using the staging env locally, go to Local PRJ-3946 | 2023 RAPID Facility 4-Day Workshop
  2. In another window, go to Staging https://hazmapper.tacc.utexas.edu/staging/project/42591a9a-172f-4675-a7b5-875f5f319e5c
  3. Click through the various questionnaires and compare local with staging to make sure they look as expected.

UI Photos:

Screenshot 2025-01-23 at 1 55 25 PM

Notes:

- Lifts questionnaireBuilder directly from angular
- Only change is the way newer version of uuid imports uuidv4
 - styles, hooks, and package imports
@sophia-massie sophia-massie requested review from nathanfranklin and rstijerina and removed request for nathanfranklin January 23, 2025 20:03
@sophia-massie sophia-massie marked this pull request as ready for review January 23, 2025 20:03
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sophia-massie sophia-massie merged commit fd4a82e into main Jan 24, 2025
5 checks passed
@sophia-massie sophia-massie deleted the task/WG-411-Questionnaire-Modal-LTS branch January 24, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants