-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task/WG-401-Add-Asset-to-Feature-Hook #308
Conversation
type="primary" | ||
onClick={handleSubmit} | ||
isLoading={isImporting} | ||
disabled={isImportingSuccess} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The use of isSuccess to disable the button is a good idea 💯. but needs to be specific to a particular feature (i.e. projecteId + featureId) and then the mutation's isSuccess is also tricky as it is not cached. 🤔 Let's just make a mental note and revisit this in February.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely. I will note to build out the hook state and button handling to be more robust when I'm using the modal to handle the submit.
Co-authored-by: Nathan Franklin <[email protected]>
LGTM 👍 🦖 |
Overview:
Adds hook with hardcoded values to add an asset to a feature
PR Status:
Related Jira tickets:
Summary of Changes:
Testing Steps:
/TODO Replace with passed in values from FileBrowserModal. These are hardcoded to test./
UI Photos:
Final Result
Notes: