Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: TV3-181 add ptatax_assets #260

Merged
merged 1 commit into from
Jan 9, 2024
Merged

feat: TV3-181 add ptatax_assets #260

merged 1 commit into from
Jan 9, 2024

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jan 9, 2024 •
edited
Loading

Overview

Add assets for PTDataX in new directory ptdatax_assets.

Related

Changes

  • added ptdatax_assets with logo and favicon

Testing

  1. Build and deploy.
  2. Verify logo is "DATA X" from production site.
  3. Verify favicon is the icon from the logo.
  4. Verify favicon and logo are remote assets.
Regression Test
  1. Verify available templates are only "Standard" and "Full Width".
    Requires login.
  2. Verify stylesheets use Core-Styles v2.
  3. Verify Portal Nav is present.
  4. Verify Search Bar is not present.

UI

Logo Favicon
logo favicon
https://cdn.jsdelivr.net/gh/TACC/Core-CMS-Custom@feat/TV3-181-add-ptdatax-resources/ptdatax_assets/logo.png https://cdn.jsdelivr.net/gh/TACC/Core-CMS-Custom@feat/TV3-181-add-ptdatax-resources/ptdatax_assets/favicon.ico

This was referenced Jan 9, 2024
Merged
Closed
@wesleyboar wesleyboar changed the title feat(ptdatax): TV3-181 add assets feat: TV3-181 add ptatax_assets Jan 9, 2024
@wesleyboar wesleyboar merged commit 813aa7c into main Jan 9, 2024
@wesleyboar wesleyboar deleted the feat/TV3-181-add-ptdatax-resources branch January 9, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rstijerina rstijerina rstijerina approved these changes

@taoteg taoteg Awaiting requested review from taoteg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesleyboar @rstijerina