Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/WP-798: Setup Defaults for Query Client #395

Open
wants to merge 5 commits into
base: feat/apcd-react-conversion
Choose a base branch
from

Conversation

jalowe13
Copy link
Collaborator

@jalowe13 jalowe13 commented Dec 6, 2024

Overview

Setup defaults for query client

Related

Changes

  • Defaults for QueryClientProvider wrapper around Components

Testing

  1. Add the following line to src/client/src/main.tsx:32
console.log(queryClient.getQueryCache());
  1. Navigate to a new page and check in the console if the Query options match the following
    {staleTime: 300000, cacheTime: 600000, refetchOnWindowFocus: false, queryKey: Array(1), queryFn: ƒ, ...}

UI

image

@jalowe13 jalowe13 marked this pull request as ready for review December 11, 2024 21:50
Copy link
Contributor

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove existing usages of staleTime in
useUserFilters and useSubmissionFilters (and in anyother place in the code).
These defaults should help instead of values at each hook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants