Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lccf): cms menu .nav-link alignment #409

Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix(lccf): cms menu .nav-link alignment #409

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00415a1
fix(lccf): cms menu .nav-link alignment
wesleyboar Jan 15, 2025
ef0242c
docs(lccf): comments
wesleyboar Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 23 additions & 14 deletions lccf_assets/header.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
.portal-logo {
height: 80px;
}

/* To increase vertical space of header */
.s-header.navbar {
--nav-padding-vert: 10px;
}
Expand All @@ -13,20 +15,27 @@
}
}

/* To fix position (given header resize code that does not consider everything) */
/* To fix nav link alignment regardless the nav padding */
/* TODO: Fix this in Core-Styles instead */
:root {
/* NOTE: Use this in Core-Styles `.s-header { … border-bottom: … }` */
--header-major-border-width: 1px;
}
.s-header .nav-link {
top: unset;
--move-text-back-to-middle: var(--nav-padding-vert);
--move-underline-to-bottom: calc( var(--nav-padding-vert) + var(--header-major-border-width) );
border-color: var(--header-bkgd-color);
border-style: solid;
border-width: 0 0 var(--border-width);
/* HACK: To overwrite pseudo states use !important (not needed once in Core-Styles) */
margin-bottom: calc(var(--move-underline-to-bottom) * -1) !important;
height: calc( 100% + var(--move-underline-to-bottom) + var(--move-text-back-to-middle) );
top: calc( var(--move-text-back-to-middle) * -1 );
line-height: unset;
}

/* To accomodate dark logo */
/*
:root {
--header-text-color: var(--global-color-primary--x-dark);
--header-bkgd-color: var(--global-color-primary--x-light);
--header-minor-border-color: var(--global-color-primary--normal);
--header-major-border-color: var(--global-color-primary--normal);
--header-search-brdr-color: #D8D8D8;
--header-search-bkgd-color: var(--global-color-primary--xx-light);
--menu-toggle-icon: invert(100%);
.s-header .nav-item.active .nav-link,
.s-header .nav-link:active,
.s-header .nav-link:focus,
.s-header .nav-link:hover {
border-color: var(--global-color-secondary--light);
}
*/