-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FP-1249: Frontera Homepage Article Styles #62
Draft
wesleyboar
wants to merge
37
commits into
main
Choose a base branch
from
task/GH-93-GH-142-GH-133-article-list-plugins-and-styles
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
FP-1249: Frontera Homepage Article Styles #62
wesleyboar
wants to merge
37
commits into
main
from
task/GH-93-GH-142-GH-133-article-list-plugins-and-styles
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GH-93: Move horz outline-offset to Frontera s-home GH-93: Frontera: banner: Use old s-article-preview GH-93: Frontera: Cleanup s-home as GH-93 completes GH-93: Frontera: Demote Deprecated Core Styles Also, update markup to be accurate for for a class within these styles. GH-93: Frontera: Noop: Clean up deprecated styles
wesleyboar
changed the title
WIP: GH-93: Drop old styles for new global styles
GH-93, GH-142, GH-133: Article List Plugins+Styles
Jul 13, 2021
wesleyboar
changed the title
GH-93, GH-142, GH-133: Article List Plugins+Styles
GH-93, GH-142, GH-133: Article List Plugins & Styles
Jul 13, 2021
7 tasks
…le-list-plugins-and-styles
Ensure heading turns white.
Closed
wesleyboar
changed the title
GH-93, GH-142, GH-133: Article List Plugins & Styles
Frontera Homepage Article Styles — for Core-CMS #93, #142, #133
Sep 1, 2021
wesleyboar
changed the title
Frontera Homepage Article Styles — for Core-CMS #93, #142, #133
Frontera Homepage Article Styles (req. for Core-CMS #93, #142, #133)
Sep 1, 2021
wesleyboar
changed the title
Frontera Homepage Article Styles (req. for Core-CMS #93, #142, #133)
Frontera Homepage Article Styles
Sep 1, 2021
wesleyboar
changed the title
Frontera Homepage Article Styles
FP-1249: Frontera Homepage Article Styles
Dec 22, 2021
This lets me remove a snippet on Frontera homepage: "Hack: CSS: Temp Manual Tweak for Homepage Banner Article Titles"
Apply GH-287 snippet's code to non-plugin article styles. This file was deprecated, but must come back, cuz we abandoned plugins.
Cleanup then Migrate Frontera Homepage Snippet: "GH-93: CSS: Article List Styles - Update Non-Plugin Styles"
I deleted code that I shouldn't have. (The migration of code was fine.)
These are now loaded from core-styles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do
Overview
Cleanup Article styles now that Article plugins are gone.
Changes
Issues
Testing
Notes
Why Retain Styles for Frontera Homepage Articles Without Plugins?
Because the homepage is not automatically updated upon deploy to use the new plugins. It still expects old article styles, until it is manually updated to use the new plugins. After plugins are used, the deprecated styles may be deleted. For more insight, see "Timeline for Homepage Deploys".
Why Are There Still Project-Specific Styles?
Project-specific styles keep coming because project-specific designs come before Core designs.
Weren't There⚠️ 's in This PR Description?
Yes. But, I fixed the problem: fd1eb8f
Timeline for Homepage Deploys
(Abandoned) Deploy of this PR with corresponding Core-CMS PR will support Frontera homepage articles with or without plugins.Footnotes
Because article plugins were abandoned. ↩