Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FP-1249: Frontera Homepage Article Styles #62

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 13, 2021

To Do

  • Add fixes from production homepage snippets.
    • Duplicate changes/snippets to pre-prod.
    • Duplicate changes/snippets to dev.
  • Consider integration of useful improvements from unused PR:
  • Remove plugin styles. Restore non-plugin styles.1
  • Merge in main (and resolve conflicts). — 2023-11-13
  • Re-test this PR.

Overview

Cleanup Article styles now that Article plugins are gone.

Changes

  • Remove styles that supported Frontera homepage articles with plugins.
  • Update styles to support Frontera homepage articles sans plugins.

Issues

Testing

Notes

  1. Why Retain Styles for Frontera Homepage Articles Without Plugins?

    Because the homepage is not automatically updated upon deploy to use the new plugins. It still expects old article styles, until it is manually updated to use the new plugins. After plugins are used, the deprecated styles may be deleted. For more insight, see "Timeline for Homepage Deploys".

  2. Why Are There Still Project-Specific Styles?

    Project-specific styles keep coming because project-specific designs come before Core designs.

  3. Weren't There ⚠️'s in This PR Description?

    Yes. But, I fixed the problem: fd1eb8f

  4. Timeline for Homepage Deploys
    1. Styles were added via GH-93: Article List Styles Core-CMS#264 to support Frontera homepage articles without plugins.
    2. Plugins were added via GH-93, GH-142, GH-133: Article List Plugins & Styles Core-CMS#280 to support Frontera homepage articles with plugins.
    3. @tacc-wbomar realized deploy of that CMS PR would break existing Frontera homepage articles without plugins.
    4. The styles to support Frontera homepage articles without plugins are deprecated but still loaded via this PR.
    5. (Abandoned) Deploy of this PR with corresponding Core-CMS PR will support Frontera homepage articles with or without plugins.
    6. Frontera homepage was updated to not use plugins.
    7. (To Do) After deploy, styles this PR deprecates may be safely removed.

Footnotes

  1. Because article plugins were abandoned.

GH-93: Move horz outline-offset to Frontera s-home

GH-93: Frontera: banner: Use old s-article-preview

GH-93: Frontera: Cleanup s-home as GH-93 completes

GH-93: Frontera: Demote Deprecated Core Styles

Also, update markup to be accurate for for a class within these styles.

GH-93: Frontera: Noop: Clean up deprecated styles
@wesleyboar wesleyboar changed the title WIP: GH-93: Drop old styles for new global styles GH-93, GH-142, GH-133: Article List Plugins+Styles Jul 13, 2021
@wesleyboar wesleyboar changed the title GH-93, GH-142, GH-133: Article List Plugins+Styles GH-93, GH-142, GH-133: Article List Plugins & Styles Jul 13, 2021
@wesleyboar wesleyboar mentioned this pull request Aug 26, 2021
@wesleyboar wesleyboar changed the title GH-93, GH-142, GH-133: Article List Plugins & Styles Frontera Homepage Article Styles — for Core-CMS #93, #142, #133 Sep 1, 2021
@wesleyboar wesleyboar changed the title Frontera Homepage Article Styles — for Core-CMS #93, #142, #133 Frontera Homepage Article Styles (req. for Core-CMS #93, #142, #133) Sep 1, 2021
@wesleyboar wesleyboar changed the title Frontera Homepage Article Styles (req. for Core-CMS #93, #142, #133) Frontera Homepage Article Styles Sep 1, 2021
@wesleyboar wesleyboar added the paused Started but not actively in progress label Oct 27, 2021
@wesleyboar wesleyboar changed the title Frontera Homepage Article Styles FP-1249: Frontera Homepage Article Styles Dec 22, 2021
This lets me remove a snippet on Frontera homepage:
"Hack: CSS: Temp Manual Tweak for Homepage Banner Article Titles"
Apply GH-287 snippet's code to non-plugin article styles.

This file was deprecated, but must come back, cuz we abandoned plugins.
@wesleyboar wesleyboar removed the paused Started but not actively in progress label Mar 9, 2022
@wesleyboar wesleyboar marked this pull request as draft March 10, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant