Skip to content

Commit

Permalink
enhance: white headings in s-footer (#391)
Browse files Browse the repository at this point in the history
* enhance: white headings in s-footer

* build: :--headings less verbose
  • Loading branch information
wesleyboar authored Sep 6, 2024
1 parent 88dcef4 commit fb8147b
Show file tree
Hide file tree
Showing 7 changed files with 51 additions and 15 deletions.
2 changes: 1 addition & 1 deletion dist/core-styles.cms.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-styles.portal.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/trumps/s-footer.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/lib/_imports/tools/selectors.common.css
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ Styleguide Tools.CustomSelectors.MultipleElements
@custom-selector :--main-content [role="main"], main;
@custom-selector :--portal-content #root;
@custom-selector :--modal .modal;
@custom-selector :--heading :is(h1, h2, h3, h4, h5, h6);
@custom-selector :--heading h1, h2, h3, h4, h5, h6;
6 changes: 6 additions & 0 deletions src/lib/_imports/trumps/s-footer.css
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import url("../tools/selectors.css");

@import url("./s-footer.properties.css");

.s-footer {
Expand All @@ -23,6 +25,10 @@
color: var(--global-color-accent--light-old);
}

.s-footer :--heading {
color: var(--global-color-primary--xx-light);
}

/* Let paragraphs behave normally */
.s-footer > p {
margin: revert;
Expand Down
8 changes: 8 additions & 0 deletions src/lib/_imports/trumps/s-footer/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,11 @@ variants:
context:
shouldLoadPortal: true
shouldSkipPattern: true
- name: complex
status: prototype
context:
modifier: thick
isComplex: true
bodyContent: More complex footers may inlcude heading(s) and list(s) of links.
shouldLoadCMS: true
shouldLoadBootstrap: true
44 changes: 33 additions & 11 deletions src/lib/_imports/trumps/s-footer/s-footer.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,41 @@
Sample body content. Footer is at bottom of page.
{{/if}}
</p>
<p>
{{#if shouldLoadCMS}}
CMS always uses <a href="{{path '../detail/s-footer--thick'}}" target="_parent">thick</a> footer.
{{else if shouldLoadPortal}}
Portal always uses <a href="{{path '../detail/s-footer--thin'}}" target="_parent">thin</a> footer.
{{/if}}
<p>
CMS always uses <a href="{{path '../detail/s-footer--thick'}}" target="_parent">thick</a> footer.
</p>
</main>
<footer class="s-footer{{#if modifier }} s-footer--{{ modifier }}{{/if}}">
{{/if}}{{#if shouldLoadPortal}}
<p>
©2023
<a href="https://www.tacc.utexas.edu/" target="_blank">Texas Advanced Computing Center</a>,
<a href="https://www.utexas.edu/" target="_blank">The University of Texas at Austin</a>,
<a href="https://research.utexas.edu/" target="_blank">Office of the Vice President for Research</a>.
Portal always uses <a href="{{path '../detail/s-footer--thin'}}" target="_parent">thin</a> footer.
</p>
{{/if}}{{#if shouldLoadBootstrap}}
<p>
This pattern is not protected from Bootstrap side-effects (e.g. heading margin).
</p>
{{/if}}
</main>
<footer class="s-footer{{#if modifier }} s-footer--{{ modifier }}{{/if}}">
{{#if isComplex}}
<div style="text-align:left;">
<h4>About</h4>
<p>
<a href="#">About TACC</a><br>
<a href="#">Jobs at TACC</a><br>
<a href="#">Contact</a><br>
<a href="#">Staff Directory</a><br>
<a href="#">Tours</a><br>
<a href="#">Citing TACC</a><br>
<a href="#">Security and Compliance</a><br>
<a href="#">Help</a>
</p>
</div>
{{else}}
<p>
©2023
<a href="https://www.tacc.utexas.edu/" target="_blank">Texas Advanced Computing Center</a>,
<a href="https://www.utexas.edu/" target="_blank">The University of Texas at Austin</a>,
<a href="https://research.utexas.edu/" target="_blank">Office of the Vice President for Research</a>.
</p>
{{/if}}
</footer>

0 comments on commit fb8147b

Please sign in to comment.