Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/tup-488: Make scrollable border … not scrollable #263

Closed
wants to merge 2 commits into from

Conversation

R-Tomas-Gonzalez
Copy link
Collaborator

@R-Tomas-Gonzalez R-Tomas-Gonzalez commented Nov 17, 2023

Overview

This commit allows the border-top to stay put when scrolling the tbody up and down.

Related

Changes

  • Adds
thead :is(td, th) {
    border-bottom: var(--global-border-width--normal) solid var(--global-color-primary--dark);
}

to table.cms.css

  • Removes
tbody > tr:first-child > :is(td, th),
:--s-paragraph-table {
  border-top: var(--global-border-width--normal) solid var(--global-color-primary--dark);

from table--basic.css

Testing

  1. http://localhost:3000/components/detail/o-fixed-header-table
  2. Tomas could not test changes on tup-ui... Doesn't know how to pull up the table on tup-ui

UI

Top Border Stays When Scrolled
Screenshot 2023-11-17 at 11 06 42 AM

Notes

Adjusting border the way we did, in the thead, may create an issue. It allows the body to ever so slightly be seen behind the thead. Possible fix is making top: -1px. Any other ideas welcomed.

Bug
Screenshot 2023-11-17 at 10 41 45 AM
Answer: This was not just a me thing.
Posible Fix
Screenshot 2023-11-17 at 10 46 56 AM

@R-Tomas-Gonzalez R-Tomas-Gonzalez added fix Fixes user-facing behavior or feature minor A feature in backward-compatible manner labels Nov 17, 2023
@wesleyboar
Copy link
Member

I mislead you yesterday. I'm gonna try to do this one, because I'm having trouble making sure nothing unexpectedly breaks.

@wesleyboar wesleyboar added patch A backward-compatible fix and removed minor A feature in backward-compatible manner labels Nov 17, 2023
@wesleyboar
Copy link
Member

Closing in favor of #265.

@wesleyboar wesleyboar closed this Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants