Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: admonition type "tip" has no color #374

Merged
merged 1 commit into from
Aug 23, 2024
Merged

fix: admonition type "tip" has no color #374

merged 1 commit into from
Aug 23, 2024

Conversation

wesleyboar
Copy link
Member

Overview

Make sure .admonition.tip has color via message-extra.

Related

Changes

  • renamed message-tip to message-extra
  • added missing custom selector for …extra f.k.a …tip

Testing

  1. Open http://localhost:3000/components/preview/admonition.
  2. Verify "Tip" admonition has blue background.

UI

before after
before after

@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Aug 23, 2024
@wesleyboar wesleyboar added the patch A backward-compatible fix label Aug 23, 2024
@wesleyboar wesleyboar merged commit a5d193f into main Aug 23, 2024
2 of 5 checks passed
@wesleyboar wesleyboar deleted the fix/admonition-tip-no-color branch August 23, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar