Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: white headings in s-footer #391

Merged
merged 2 commits into from
Sep 6, 2024
Merged

enhance: white headings in s-footer #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
316fce2
enhance: white headings in s-footer
wesleyboar Sep 6, 2024
c71cd0a
build: :--headings less verbose
wesleyboar Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/core-styles.cms.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-styles.portal.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/trumps/s-footer.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/lib/_imports/tools/selectors.common.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ Styleguide Tools.CustomSelectors.MultipleElements
@custom-selector :--main-content [role="main"], main;
@custom-selector :--portal-content #root;
@custom-selector :--modal .modal;
@custom-selector :--heading :is(h1, h2, h3, h4, h5, h6);
@custom-selector :--heading h1, h2, h3, h4, h5, h6;
6 changes: 6 additions & 0 deletions src/lib/_imports/trumps/s-footer.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import url("../tools/selectors.css");

@import url("./s-footer.properties.css");

.s-footer {
Expand All @@ -23,6 +25,10 @@
color: var(--global-color-accent--light-old);
}

.s-footer :--heading {
color: var(--global-color-primary--xx-light);
}

/* Let paragraphs behave normally */
.s-footer > p {
margin: revert;
Expand Down
8 changes: 8 additions & 0 deletions src/lib/_imports/trumps/s-footer/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,11 @@ variants:
context:
shouldLoadPortal: true
shouldSkipPattern: true
- name: complex
status: prototype
context:
modifier: thick
isComplex: true
bodyContent: More complex footers may inlcude heading(s) and list(s) of links.
shouldLoadCMS: true
shouldLoadBootstrap: true
44 changes: 33 additions & 11 deletions src/lib/_imports/trumps/s-footer/s-footer.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,19 +6,41 @@
Sample body content. Footer is at bottom of page.
{{/if}}
</p>
<p>
{{#if shouldLoadCMS}}
CMS always uses <a href="{{path '../detail/s-footer--thick'}}" target="_parent">thick</a> footer.
{{else if shouldLoadPortal}}
Portal always uses <a href="{{path '../detail/s-footer--thin'}}" target="_parent">thin</a> footer.
{{/if}}
<p>
CMS always uses <a href="{{path '../detail/s-footer--thick'}}" target="_parent">thick</a> footer.
</p>
</main>
<footer class="s-footer{{#if modifier }} s-footer--{{ modifier }}{{/if}}">
{{/if}}{{#if shouldLoadPortal}}
<p>
©2023
<a href="https://www.tacc.utexas.edu/" target="_blank">Texas Advanced Computing Center</a>,
<a href="https://www.utexas.edu/" target="_blank">The University of Texas at Austin</a>,
<a href="https://research.utexas.edu/" target="_blank">Office of the Vice President for Research</a>.
Portal always uses <a href="{{path '../detail/s-footer--thin'}}" target="_parent">thin</a> footer.
</p>
{{/if}}{{#if shouldLoadBootstrap}}
<p>
This pattern is not protected from Bootstrap side-effects (e.g. heading margin).
</p>
{{/if}}
</main>
<footer class="s-footer{{#if modifier }} s-footer--{{ modifier }}{{/if}}">
{{#if isComplex}}
<div style="text-align:left;">
<h4>About</h4>
<p>
<a href="#">About TACC</a><br>
<a href="#">Jobs at TACC</a><br>
<a href="#">Contact</a><br>
<a href="#">Staff Directory</a><br>
<a href="#">Tours</a><br>
<a href="#">Citing TACC</a><br>
<a href="#">Security and Compliance</a><br>
<a href="#">Help</a>
</p>
</div>
{{else}}
<p>
©2023
<a href="https://www.tacc.utexas.edu/" target="_blank">Texas Advanced Computing Center</a>,
<a href="https://www.utexas.edu/" target="_blank">The University of Texas at Austin</a>,
<a href="https://research.utexas.edu/" target="_blank">Office of the Vice President for Research</a>.
</p>
{{/if}}
</footer>
Loading