Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bootstrap): .col-dark not registered as dark context #415

Merged
merged 3 commits into from
Oct 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/components/bootstrap/bootstrap--col.demo.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/components/bootstrap/demo.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/core-styles.cms.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-styles.demo.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/settings/color--cms.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/settings/color--demo.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions src/lib/_imports/components/bootstrap/bootstrap--col.demo.css
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,9 @@
.col > p {
margin-block: 1rem
}

.demo-buttons {
display: flex;
flex-wrap: wrap;
gap: 0.5em;
}
12 changes: 9 additions & 3 deletions src/lib/_imports/components/bootstrap/bootstrap--col.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@
<div class="col">
<article class="c-card c-card--plain">
<h3>Regular</h3>
<p>{{> @text-of-one-paragraph-short }}</p>
<p>{{> @text-of-one-sentence }}</p>
</article>
<p>Regular columns support many direct children.</p>
<p>Buttons can change color per section.</p>
<div class="demo-buttons">{{> @button-samples }}</div>
</div>
<div class="col">
<article class="c-card c-card--plain">
Expand All @@ -51,9 +53,11 @@
<div class="col col-muted">
<article class="c-card c-card--plain">
<h3>Regular</h3>
<p>{{> @text-of-one-paragraph-short }}</p>
<p>{{> @text-of-one-sentence }}</p>
</article>
<p>Regular columns support many direct children.</p>
<p>Buttons can change color per section.</p>
<div class="demo-buttons">{{> @button-samples }}</div>
</div>
<div class="col col-muted">
<article class="c-card c-card--plain">
Expand All @@ -79,9 +83,11 @@
<div class="col col-dark">
<article class="c-card c-card--plain">
<h3>(Regular)</h3>
<p>{{> @text-of-one-paragraph-short }}</p>
<p>{{> @text-of-one-sentence }}</p>
</article>
<p>Regular columns support many direct children.</p>
<p>Buttons can change color per section.</p>
<div class="demo-buttons">{{> @button-samples }}</div>
</div>
<div class="col col-dark">
<article class="c-card c-card--plain">
Expand Down
2 changes: 1 addition & 1 deletion src/lib/_imports/settings/color--cms.css
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
@custom-selector :--dark-context
.c-recognition--style-dark,
:--o-section--dark,
.col-dark
.col-dark,
.s-footer;

@custom-selector :--light-context-safe
Expand Down
Loading