fix: s-header nav-link alignment inconsistent

[wesleyboar]

Overview

Fix vertical alignment of .nav-links in CMS menu to work regardless of navbar height and width.

Inconsistency can occur on all sites using TACC_CORE_STYLES_VERSION = 2 but is most-noticeable on LCCF, because LCCF sets .s-header.navbar { --nav-padding-vert: 10px; }.

Related

• fixes & standardizes fix(lccf): cms menu .nav-link alignment Core-CMS-Custom#409
• required by fix(lccf): align cms menu nav link via Core-Styles Core-CMS-Custom#410

Changes

• fixes & refactors header nav link styles

Testing

1. Replace the content of a site's core-styles.header.css with new dist.
   1. https://dev.cep.tacc.utexas.edu
   2. https://pprd.lccf-portal.tacc.utexas.edu
      _{fix(lccf): align cms menu nav link via Core-Styles Core-CMS-Custom#410}
2. View when navbar is expanded.
   1. Verify .nav-link underline is at bottom of header.
   2. Verify .nav-link text is vertically aligned center with search bar.
3. View when navbar is collapsed.
   1. Verify .nav-links are not too close to each other.

UI

…