Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: update pills too large or missing #347

Merged
merged 4 commits into from
Nov 9, 2023
Merged

hotfix: update pills too large or missing #347

merged 4 commits into from
Nov 9, 2023

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Oct 13, 2023 •
edited
Loading

Overview / Changes

  • Don't let update pill be so large.
  • Use a pill for "Original Message".
  • Don't add margin-left on pills on an update page.

Related

None

Testing

  1. Open https://www.tacc.utexas.edu/news/user-updates/107489/.
  2. Verify pill is not so big.
  3. Verify "Original Message" text is in a gray pill and same size as update pill.
  4. ❗️ Verify, on an update page, "Update" and "Original Message" pills do not have margin-left.
  5. ❗️ Verify, on an update list, "Update" does have margin-left.

UI

Update

before after
before after

Original Message

before after
before after

@wesleyboar wesleyboar marked this pull request as ready for review October 13, 2023 22:01
@wesleyboar wesleyboar changed the title fix: update pill too large hotfix: update pill too large Oct 13, 2023
@wesleyboar wesleyboar changed the title hotfix: update pill too large hotfix: update pills too large or missing Oct 13, 2023
R-Tomas-Gonzalez
R-Tomas-Gonzalez approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@R-Tomas-Gonzalez R-Tomas-Gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Changes are there when testing.

@jarosenb jarosenb merged commit 60571a0 into main Nov 9, 2023
1 check passed
@jarosenb jarosenb deleted the hotfix/user-update-pills-too-large branch November 9, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R-Tomas-Gonzalez R-Tomas-Gonzalez R-Tomas-Gonzalez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wesleyboar @R-Tomas-Gonzalez @jarosenb