-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: core-cms v4.8 & core-styles v2.25 #436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
changed the title
feat: core-cms v4.8 & core-styles v2.25
feat: core-cms v4.8 & core-styles v2.25 ⚠️
Mar 4, 2024
wesleyboar
changed the title
feat: core-cms v4.8 & core-styles v2.25 ⚠️
feat: core-cms v4.8 & core-styles v2.25
Mar 5, 2024
wesleyboar
commented
Mar 5, 2024
Comment on lines
-13
to
+14
{% with settings.FAVICON as favicon %} | ||
<link rel="icon" href="{% static favicon.img_file_src %}" type="image/x-icon" /> | ||
{% with settings.PORTAL_FAVICON as favicon %} | ||
<link rel="icon" href="{% if favicon.is_remote %}{{ favicon.img_file_src }}{% else %}{% static favicon.img_file_src %}{% endif %}" type="image/x-icon" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To support TACC/CMS#v4.7.0: CDN Logo & Favicon via PORTAL_LOGO / PORTAL_FAVICON.1
Footnotes
-
Mimics part of the changes in refactor: cmd-79 rename tacc cms settings #416. ↩
R-Tomas-Gonzalez
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update Core-CMS & Core-Styles to latest versions.
Related
TUP-702→ CMD-104TUP-703→ CMD-103Changes
Core-CMS
Core-Styles
s-app-card
, Fix<hr>
, Hack for Bootstrap 3Testing
Core-CMS
Create/View news filtered by tag e.g. https://tacc.utexas.edu/news/latest-news/tag/frontera/. Verify it looks like "NEWS — Frontera" (where "Frontera" is the tag name)
i.e. TUP-707
View/Add link to external site that does not have
target="_blank"
set. Reload page. Verify link markup is given bothtarget="_blank"
andaria-description="Opens in new window"
.i.e. TUP-702
Test on TUP. Load homepage. Verify all home page banner links do not open in a new window.
i.e. TUP-707
Core-Styles on CMS
View/Add a table. View on narrow screen. Verify it still looks CMS table.
i.e. does not have TUP-534 yet
Sample Markup
View/Add a button pattern with less text and wide width. Verify text is centered.
i.e. TACC/Core-Styles#307
Sample Markup
View/Add a tag pattern. Verify it has
padding
of0.25rem 0.5rem 0rem
(source).TACC/Core-Styles#301
Sample Markup
View/Add an
<hr>
. Verify it does not havewidth: 100%
.i.e. TACC/Core-Styles#310
Sample Markup
Cause a CMS form error — one way is to fill out form, throttle network to appear offline, and submit form. Verify form error has correct padding.
i.e. Check that TUP-676 is fixed.
Core-Styles on Portal
i.e. TACC/Core-Styles#307
UI
Core-CMS
frontera
Core-Styles on CMS
Core-Styles on Portal