Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make submit poll add/edit button tell what it will do: add or save #2071

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

vadosnaprimer
Copy link
Collaborator

@vadosnaprimer vadosnaprimer commented Jan 18, 2025

Currently it says "edit" which everywhere else means "open the page where the thing can be edited, and then that edit can be saved separately, or canceled".

I wanted to see if I can edit poll options after some votes, and the button says "edit" so I expected it to send me to some extra editing page (even tho I was already on one), and that overrode poll duration, which is always rounded down to whole days and right after you set it to some amount of days, it will decrease by 1, so accidentally saving that messes up actual duration.

currently it says "edit" which everywhere else means "open the page where the thing can be edited, and then that edit can be saved separately", or canceled

I wanted to see if I can edit poll options after some votes, and the button says "edit" so I expected it to send me to some extra editing page (even tho I was already on one), and that overrode poll duration, which is always rounded down to whole days and right after you set it to some amount of days, it will decrease by 1, so accidentally saving that messes up actual duration.
@adelikat adelikat merged commit 28144c6 into main Jan 18, 2025
1 check passed
@adelikat adelikat deleted the poll-button branch January 18, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants