Add auto shotgun swep

[yousifhub]

adding a shotgun that makes the normal hl2 shotgun faster no cocking and faster reload and another version for admins to have fun and does more damage than the non-admin one

[yogwoggf]

I think the code could greatly benefit from extracting constant values you use in the attack functions to constant variables grouped at some part of the file (preferably the top)

Also, is it necessary for the cat picture to have a material bound to it?

[yogwoggf]

Forgot to mention in the original review but I think you should rename the weapon file to weapon_autoshotgun instead of weapon_Auto_Shotgun since traditionally weapon names are all lowercase.

[yogwoggf]

LGTM. The PR will be merged once someone can do QA and it passes without any blockers.

[Derpius]

It doesn't look like you've added the resources to be downloaded by clients using https://wiki.facepunch.com/gmod/resource

[yousifhub]

Not really sure if SWEP.ShootSound = Sound("weapons/xm1014/xm1014-1.wav") people without css will hear but
their problem since people mostly got css since its mostly used in servers

[Derpius]

@yousifhub can you please add the unrelated changes to separate feature branches and PRs.

This should just be for the auto shotgun, and not everything you’re working on. Otherwise we’re forced to merge either everything or nothing.

Also, the extra hud isn’t a swep, so it should be in a different repository entirely

[Derpius]

Looks fine now bar the seemingly unused shoot and reload sounds. Just needs someone to QA (@yogwoggf you have lots of free time and not much experience doing QAs )

[Derpius]

If these files are unused can they be removed?

[yogwoggf]

Will probably do the QA on the weekend, although, @yousifhub - you do have merge conflicts because you accidently removed el patito from the authors list.

[Derpius]

@yogwoggf merge conflicts resolved

[yogwoggf]

QA Result: Failed ❌

Blockers ❌

• When re-equipping the weapon after spawning it from the weapons tab in the spawnmenu, the swep will error locally and cause a lua error. ❌
  • The error: [sweps] addons/sweps/lua/weapons/weapon_autoshotgun.lua:49: attempt to call method 'GiveAmmo' (a nil value) 1. unknown - addons/sweps/lua/weapons/weapon_autoshotgun.lua:49 (x12)
• Similar to the first blocker, the entire logic for the giving ammo on the first deploy is broken and doesn't actually run when spawned. ❌
  • Furthermore, it's shadowed by the original SWEP logic that is being used anyways (SWEP.Primary.DefaultClip = 30)
  • I would remove it entirely
• When the clip is empty, the secondary attack (right mouse button) spams the empty click sound each frame, resulting in a discordant sound. ❌
  • I'm arguing this is a blocker as it can easily cause someone to get startled if they're using headphones

Warnings ⚠️

• Kill icon is not specified ⚠️
  • Causes a warning in the console
  • In my opinion, I think it could just be set to the normal shotgun icon
• There is a "cat.vtf" and a "cat.vmt" but also a "cat.jpg" in materials/ ⚠️
  • Choose one or the other, it's unnecessary to have different formats, especially as GMod has first-class support for jpegs.
  • Your code also flip flops between the vmt and the jpg.

Passed ✅

• Primary fire ✅
  • Fires ordinary shotgun bullets
  • Takes 1 ammo out of the clip
  • Plays fire sound correctly
• Secondary fire ✅
  • Fires three shotgun bullets
  • Takes 3 ammos out of the clip
  • Plays fire sound correctly
  • Won't fire if less than 3 ammos in clip
• HUD ✅
  • Icon appears correctly in spawnmenu
  • Icon appears decently correct in weapon selection (stretched)
• Appearance ✅
  • World model is a shotgun
  • View model is the normal shotgun
  • FoV is correct
  • Hold type is shotgun, so correct

[yogwoggf]

Re-QA Result: Passed with Warnings ✅

Warnings ⚠️

• There are still the 3 redundant files of the icon. ⚠️

Passed ✅

• When re-equipping the weapon after spawning it from the weapons tab in the spawnmenu, the swep will error locally and cause a lua error. ✅
• The entire logic for the giving ammo on the first deploy is broken and doesn't actually run when spawned. ✅
• When the clip is empty, the secondary attack (right mouse button) spams the empty click sound each frame, resulting in a discordant sound. ✅